Fix measure of pulse builder #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SooluThomas
requested review from
nkanazawa1989 and
taalexander
as code owners
taalexander
pushed a commit
that referenced
this pull request
Oct 16, 2020
* Enable zero rep delay * Add backend fix Co-authored-by: Luciano Bello <luciano.bello@ibm.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
kdk
pushed a commit
that referenced
this pull request
Feb 8, 2021
* ae codes * add tests * update docstrings in result objects * add reno * fix old aqua dependencies * fix cyclic imports * try fixing windows tests no. 1 * fix test * try fixing windows attempt #2 * stefan's first comments * accumulate -> evaluate in AE * prob to meas 1 -> prob good state * stefans comments pt. 2 * fix lint & indent * add faster ae + bernoulli tests * fix > 1 qubit case * add comments * add FAE specific tests * raise error for rescale on custom q operator * play with the oracles * fix classicalregister > 1 * use correct reflection and rm X gates around oracle * fix construction of rescaled est. problem * fix phase in grover op * adjust result objects * adjust fae result object * fix minus sign and lint * rm trailing whitespaces * fix tests * fix lint * rm utf8 header * move rescale to problem, add evalschedule to MLAE * code review suggestions * state and obj.qubits not optional in estimation problem * add QAE algos to documentation * allow setting post processing and is good state to None to use default * rm quantum instance logic from interface * fix typehints for is good state * add Faster AE to reno * reset shots to user defined shots in FAE * fix doc build (hopefully) * add result classes to docs * make grover op optional in setter * rm reno -- there will be a global one Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
taalexander
pushed a commit
that referenced
this pull request
Mar 8, 2021
* change unique list to MappingView * fix test * start adding tests * handle anonymous parameter assigment * fix bind_parameters * fix compose * add reno, remove todos * fix docstring * fix inconsistent argname * fix renaming gone wrong * changes from code review * use deprecate_arguments * add deprecation section in reno * add more tests * fix naming in reno * make compose(front) more efficient * update paramtables in compose w/o iterating over all gates * properly rebuild parameterable upon compose * use params instead of param_dict * fix __new__ * fix sorting * fix tests * fix parameter order in test * Apply suggestions from code review Co-authored-by: Luciano Bello <bel@zurich.ibm.com> * rename params->parameters, update reno * add tests, remove access table by index * use ListEqual over Equal * rm unused islice import * Rm star-swallowers from bind/assign_parameters * store parent instance instead of just name * fix name `params` -> `parameters` * fix typo * fix typo #2 * add test for pickling paramvecelements Co-authored-by: Erick Winston <ewinston@us.ibm.com> Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
taalexander
pushed a commit
that referenced
this pull request
Jan 4, 2022
* Add PhaseEstimator and related classes * Fix linter complaints * Update qiskit/algorithms/phase_estimators/hamiltonian_phase_estimation.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * Fix indentation in doc string * Fix more indentation in doc string * Comment on reasons for removing identity term from Hamiltonian * Replace mistaken description "water" by "H2" * Add default phase shift of 0.0 for identity term * Remove function call from default arg Replace default arg with None, and then set the desired default in the body of the function. * Refactor _run and rename to _result Move all common code out of _run for HamiltonianPhaseEstimation and PhaseEstimation, and rename _run to _result, because it only creates the result class. * Move some inputs and calculation to estimate method * Add cutoff to filter in test_from_bound * An unknown change in the past three weeks caused tests to fail with the default filter threshold of 0 (no filtering). I added a small cutoff so that the tests pass again. * Fix linter complaints * Fix linter complaints * Allow PauliSumOp as input Hamiltonian * Make suggested changes * Move module method to classmethod * Fix indentation * Refactor scale_phase scale_phases * Make HamiltonianPhaseEstimation have a hasa rather than isa use of PE * Remove all computation from PhaseEstimator * Remove ability to set number of computation qubits in PhaseEstimator.estimate() * update to current algorithm paradigm + small fixes * make algorithms stateless (store no problem information) * fix lint and docstrings * fix cyclic imports * Use PauliTrotterEvolution by default in HamiltonianPhaseEstimation * Make HamiltonianPhaseEstmation take a StateFn for state preparation * Add method most_likely_phase to HamiltonianPhaseEstimation * Allow PauliOp as input unitary to HPE * Allow MatrixOp as input Hermitian op to HPE * Fix linter complaints * fix evolution = None case * refactor tests slightly * be explicit about which evolution is used * combine tests using ddt * add some linebreaks * fix import order * Improve docstrings for PE and HPE * attempt to fix sphinx * attempt to fix sphinx #2 * attempt no. 3 to fix sphinx * layout, don't use function calls in defaults * trailing comma Co-authored-by: Julien Gacon <gaconju@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.