Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(KL-159/리팩토링): dateparser, build optimizing etc.. #60

Merged
merged 17 commits into from
Oct 8, 2024

Conversation

sayoonnn
Copy link
Contributor

@sayoonnn sayoonnn commented Oct 8, 2024

타입(지라 이슈키): 설명

📌 연관된 이슈

지라 이슈 링크

📝 작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

  • 빌드 최적화
  • 작성일 나타내는 함수 변경

🌳 작업 브랜치명

현재 작업중인 브랜치를 적어주세요

📸 스크린샷 (선택)

💬 리뷰 요구사항 (선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

Summary by CodeRabbit

  • New Features

    • Updated the website description for improved branding.
    • Added a logout button in the user profile for enhanced user experience.
    • Enhanced date display in comments and reviews for better readability.
  • Bug Fixes

    • Improved error handling for various user actions, including logout and notifications.
  • Style

    • Updated font display properties for better rendering across different browsers.
  • Chores

    • Modified deployment workflow to trigger from the main branch.
    • Streamlined import paths for utility functions to improve code organization.
  • Refactor

    • Enhanced the date parsing utility for more user-friendly date representations.

sayoonnn and others added 11 commits October 8, 2024 14:04
- import declare를 재정렬했습니다.
- login 정보를 zustand store로 관리합니다.
- 함수 스코프 사이에 빈 줄을 삽입하였습니다.
- 오타를 수정하였습니다.
- 잘못된 절대경로 import 스타일을 수정하였습니다.
- UserEditPage에 useCheckAuth 훅을 사용하여 로그인 여부를 확인합니다.
- 빌드 최적화
: 여러군데서 사용하는 라이브러리를 하나의 파일로 분리하여 용량을 축소시켰습니다
@sayoonnn sayoonnn requested a review from seoulyego October 8, 2024 06:53
Copy link
Contributor

coderabbitai bot commented Oct 8, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several changes primarily focused on updating import paths, modifying workflow configurations, and enhancing component functionalities. Notably, the deployment trigger for AWS S3 has been changed from the develop branch to the main branch. Additionally, various components have been updated to use a new kyInstance import path, and several components have incorporated a new date parsing utility for improved date formatting.

Changes

File Path Change Summary
.github/workflows/main.yml Updated deployment trigger branch from develop to main.
index.html Updated <meta> description and modified Google Fonts <link> tag.
jsconfig.json Removed catch-all path alias mapping for "@/*": ["*"].
src/components/Comment/CommentEdit.jsx Changed import path for method from @hooks/kyInstance to @utils/kyInstance.
src/components/Comment/CommentInput.jsx Changed import path for method from @hooks/kyInstance to @utils/kyInstance.
src/components/Comment/CommentListContent.jsx Added import for dateParser and modified date rendering logic.
src/components/Comment/CommentOptions.jsx Changed import path for method from @hooks/kyInstance to @utils/kyInstance.
src/components/Notification/NotificationContent.jsx Changed import path for method from @hooks/kyInstance to @utils/kyInstance.
src/components/UserProfile/UserEditButton.jsx Added a logout button with functionality for user logout.
src/components/UserProfile/UserFollowButton.jsx Updated import path for method from @hooks/kyInstance to @utils/kyInstance and modified follow/unfollow logic.
src/hooks/useDebouncedSearch.jsx Changed import path for kyInstance from relative to absolute path.
src/hooks/useDeleteNotificationAll.js Changed import path for method from relative to absolute path.
src/hooks/useKy.js Changed import path for kyInstance from relative to absolute path.
src/hooks/useKyMutation.js Changed import path for kyInstance from relative to absolute path.
src/hooks/useKyQuery.js Changed import path for kyInstance from relative to absolute path.
src/hooks/useProductLike.js Changed import path for method from relative to absolute path.
src/hooks/useReadNotificationAll.js Changed import path for method from relative to absolute path.
src/hooks/useReviewSubmit.js Changed import path for kyInstance from relative to absolute path.
src/hooks/useUserData.js Removed dependency on useLoginStore and adjusted query enabling logic.
src/loader/feedLoader.js Changed import path for kyInstance from @hooks/kyInstance to @utils/kyInstance.
src/loader/homeLoader.js Changed import path for kyInstance from @hooks/kyInstance to @utils/kyInstance.
src/loader/meLoader.js Changed import path for kyInstance from @hooks/kyInstance to @utils/kyInstance.
src/loader/productEditLoader.js Changed import path for kyInstance from @hooks/kyInstance to @utils/kyInstance.
src/loader/productLoader.js Changed import path for kyInstance from @hooks/kyInstance to @utils/kyInstance.
src/loader/userLoader.js Changed import path for kyInstance from @hooks/kyInstance to @utils/kyInstance.
src/pages/ReviewPage/ReviewInfo.jsx Added import for dateParser and modified date rendering logic.
src/pages/ReviewPage/ReviewLikeButton.jsx Modified tooltip text for like button.
src/pages/ReviewPage/ReviewOptions.jsx Changed import path for kyInstance from @hooks/kyInstance to @utils/kyInstance.
src/pages/SubmitPage/components/PostPage.jsx Changed import path for method from @hooks/kyInstance to @utils/kyInstance.
src/pages/UserEditPage/SaveButton.jsx Updated import for kyInstance from @hooks/kyInstance to @utils/kyInstance.
src/styles/font.css Added font-display: block; to multiple @font-face declarations and modified the EduHand font's display property.
src/utils/dateParser.js Updated parameter name and enhanced logic for date formatting to include time difference calculations.
vite.config.mjs Added build property with rollupOptions to customize chunk creation during the build process.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AWS S3
    participant GitHub Actions
    User->>GitHub Actions: Push to main branch
    GitHub Actions->>AWS S3: Trigger deployment
Loading

Possibly related PRs

Suggested labels

♻️ Refactor, ⚙️ Chore

Poem

🐰 In the meadow where changes bloom,
A new path for main dispels the gloom.
With dateParser to make time clear,
And a logout button to bring us cheer!
From hooks to utils, the paths align,
In this code garden, all will be fine! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

seoulyego
seoulyego previously approved these changes Oct 8, 2024
Copy link
Contributor

@seoulyego seoulyego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 완료했습니다~!

Copy link
Contributor

@seoulyego seoulyego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

승인합니다.

@seoulyego seoulyego merged commit c20f1d2 into develop Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants