Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unescaped now only returns the tag name #119

Closed
wants to merge 2 commits into from
Closed

Unescaped now only returns the tag name #119

wants to merge 2 commits into from

Conversation

MarkDDR
Copy link
Contributor

@MarkDDR MarkDDR commented Mar 3, 2018

Fixes #118

@tafia
Copy link
Owner

tafia commented Mar 6, 2018

Could you please add a breaking example before I merge it?

@MarkDDR
Copy link
Contributor Author

MarkDDR commented Mar 7, 2018 •
edited
Loading

Doc examples added. I'm actually working on adding doc examples for most of the methods in this library so expect that some time in the future, in a different pull request of course.

@tafia
Copy link
Owner

tafia commented Mar 7, 2018

Great! Should be merged very soon once I get on my PC

@tafia
Copy link
Owner

tafia commented Mar 8, 2018

I have make a small PR on top on your request in your fork. Let me know what you think.

@tafia
Copy link
Owner

tafia commented Mar 23, 2018

Hi @mark-blum do you plan on merging my PR so I can merge yours?

@Mingun Mingun mentioned this pull request Jun 22, 2022
Merged
@Mingun Mingun closed this in #400 Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BytesStart unescaped method returns the attributes in the same result
2 participants
@MarkDDR @tafia