Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BytesStart::unescaped* set of methods because they could return wrong results #400

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

Mingun
Copy link
Collaborator

@Mingun Mingun commented Jun 22, 2022

I decide to completely remove this set of methods because they could produce misleading results.

I decide to remove example issue68.rs because of reasons:

  • it used removed method
  • it contained a bug, described in Fix caldav example #396
  • it wasn't a good example at all because of unused code and lacking of comments, instead of fixing that I think it is better to remove it completely, working with namespaces will changed soon anyway

…urn wrong results

Removed example actually did not show nothing useful and was wrong after all
@Mingun Mingun merged commit 46b4d1d into tafia:master Jun 22, 2022
@Mingun Mingun deleted the unescaped branch June 22, 2022 17:55
@dralley
Copy link
Collaborator

dralley commented Jun 23, 2022

@Mingun FYI, the benches are broken again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BytesStart unescaped method returns the attributes in the same result
2 participants