Add Hardhat Fork Functionality #3247

0xDaedalus · 2023-04-04T14:18:32Z

Necessary environment variables:

USE_MAINNET_FORK
MAINNET_FORK_URL
MAINNET_FORK_CHAIN_ID

Latest build: extension-builds-3247 (as of Fri, 16 Jun 2023 18:14:21 GMT).

This branch is a branch created from `mainnet-fork-triage` (PR #3247). It contains changes that allow for mainnet fork interactions. The branch keeps the fork config in a yarn workspace. In order to use it: ``` cd <root-folder> nvm use 16 yarn install yarn start #optional ``` And in other shell: ``` cd ci yarn install npx hardhat node --network hardhat ``` Sending txs, swapping, NFT discovery should work. No activity history. Some strange assets listed. Note that this is a WIP branch and there are some scripts and docs which should be removed before merging the branch to `main`.

In this commit we create a Hardhat project that allows for running Taho extension on a forked Mainnet. As part of this we're configuring a `hardhat` network in the Hardhat config file. The fork will begin on a block specified in the `blockNumber` parameter. The `url` parameter should hold an url to a JSON-RPC node that's based on your personal Infura/Alchemy API key (e.g. `https://mainnet.infura.io/v3/<key>`). The suggested value for `chainId` is `1337`. The steps to run the network are described in the README file. Any actions performed on the `hardhat` network will only be applied locally, they will not affect the real Mainnet network.

Shadowfiend

I would love to try moving the hardhat dependency into the ci package and removing that package from workspaces given how much yarn.lock garbage it pulls in.

What I expect would happen:

Drop hardhat from top-level package.json and drop ci from the workspaces list there as well.
Add hardhat to ci/package.json.
git checkout main -- yarn.lock to revert yarn.lock to the latest main version.
yarn install
cd ci; yarn install
Then add ci/yarn.lock.

If any of this runs into issues I think we can merge as-is rather than wasting too much more time on it though.

Shadowfiend · 2023-06-15T20:58:14Z

ci/README.md

+   `yarn install`  
+   `yarn start` (or `yarn build`)  
+   `cd ci`  
+   `npx hardhat node --network hardhat`


This can just be yarn hardhat node --network hardhat for simplicity fwiw.

Shadowfiend · 2023-06-15T20:59:22Z

ci/hardhat.config.ts

+      forking: {
+        enabled: true,
+        url: process.env.CHAIN_API_URL || "",
+        blockNumber: parseInt(process.env.FORKING_BLOCK ?? "", 10),


What happens if this is NaN? (The result of parsing "".)

Shadowfiend · 2023-06-15T20:59:48Z

ci/package.json

+{
+  "name": "@tallyho/ci",
+  "version": "0.0.1",
+  "description": "Taho, the community owned and operated Web3 wallet: window provider is responsible for creating the in-page object for communication.",


Should probably update the second part to reference CI.

Shadowfiend · 2023-06-15T21:00:11Z

package.json

@@ -56,7 +56,8 @@
    "background",
    "provider-bridge",
    "provider-bridge-shared",
-    "window-provider"
+    "window-provider",
+    "ci"


Do we need this listed as a workspace?

Shadowfiend · 2023-06-15T21:00:28Z

package.json

@@ -110,6 +111,7 @@
    "eslint-plugin-react": "^7.24.0",
    "eslint-plugin-react-hooks": "^4.2.0",
    "fork-ts-checker-webpack-plugin": "^6.3.2",
+    "hardhat": "^2.14.0",


This dependency should probably be in the ci package, no? It's unused elsewhere afaict.

This instead of a workspace in the top-level project. This allows the ci project to have its own dependencies, rather than polluting the lockfile for the top-level extension project with the large amount of hardhat dependencies.

Shadowfiend

All righty let's rock and roll 🎸

Shadowfiend · 2023-06-16T17:46:27Z

I guess also not clear to me is how much this differs from what's in dev-utils/local-chain… It feels like not at all… But we can reconcile later.

Shadowfiend

Ok but this time though let's do it lol.

@Shadowfiend

## What's Changed * Repeater Connection: Forward requests to new default when default is switched off during dApp connection flow by @Shadowfiend in #3462 * Auto-Not-So-Matic: Fix two matic.network URLs to polygon.technology by @Shadowfiend in #3483 * v0.38.0 by @kkosiorowska in #3480 * Case Dismissed: Forcibly show DAppConnectionInfoBar popover on first dApp connection by @Shadowfiend in #3464 * Add Hardhat Fork Functionality by @0xDaedalus in #3247 * Faded Jeans: Rename fadeIn class to fade_in by @Shadowfiend in #3485 * Fix issue for discovery transaction hash by @kkosiorowska in #3458 * Full Sweep: Drop the USE_UPDATED_SIGNING_UI feature flag by @Shadowfiend in #3475 * Token Discovery - Remap redux asset balances by @hyphenized in #3195 * Make specific warnings for adding custom asset by @kkosiorowska in #3478 * Run NFTs e2e tests on a controlled wallet address by @michalinacienciala in #3487 * v0.38.1 by @jagodarybacka in #3484 **Full Changelog**: v0.38.1...v0.39.0 Latest build: [extension-builds-3496](https://github.com/tahowallet/extension/suites/13792957673/artifacts/764738599) (as of Thu, 22 Jun 2023 14:27:32 GMT).

This commit introduces automated E2E tests for asset transactions and changes to the testing framework needed for the tests to run successfully. Changes to the framework include: * The changes from #3247 which added support for the hardhat functionality in the wallet's code. * Creation of a Hardhat project in `./ci` folder. In the project we configure a `hardhat` network, which is a network that's a fork of Mainnet. The fork begins on the block specified in the `blockNumber` parameter in `hardhat.config.ts` (currently it's set to `17094516`, which is a starting point for our fork-based E2E tests). Any actions performed on the `hardhat` network will only be applied locally, they will not affect the real Mainnet network. * Creation of the helper files and functions in `./e2e-tests/utils`. * Modification of the GH Actions workflow. A new job (`e2e-tests-fork`) is added to the `build.yml` workflow. The job uses the build artifact from earlier jobs, installs the project, installs Hardhat and runs the local `hardhat` network with the Mainnet fork. Then it runs the Playwright E2E tests designed for fork (the ones with `-fork` suffix) and upload the test artifacts in case of tests failure. Also the old `e2e-tests` job gets modified - it's now running only those E2E tests which are not intended for running on fork (don't contain the `-fork` suffix.) The following tests got added: * User can send base asset (executed on forked Mainnet) * User can open ERC-20 transfer from asset list and can reject the transfer (executed on forked Mainnet) * User can send ERC-20 from header (executed on forked Mainnet) * User can send base asset (executed on Goerli testnet) Most of the tests are run on Mainnet fork (to not waste the funds), but one test is run on Goerli - this is to verify the display of the transaction on the activity views (activity history doesn't work currently on fork). TODO: - [x] Change the settings of workflow artifacts accessibility (storing of artifacts turned off until we switch to importing accounts using JSON, not seed) - [x] Change the `TEST_WALLET_RECOVERY_PHRASE` secret to the seed phrase of the `testertesting.eth` wallet (**please don't do that before previous TODOs are checked!**) - [x] Once secrets are set, do final testing of the workflow - [x] Clean the testing config from the workflow once tests are done Latest build: [extension-builds-3418](https://github.com/tahowallet/extension/suites/14283396113/artifacts/802860953) (as of Thu, 13 Jul 2023 18:53:15 GMT).

0xDaedalus and others added 4 commits April 4, 2023 08:16

Add mainnet for functionality to json-rpc providers

1e8914f

Merge branch 'main' into mainnet-fork-triage

8fc7c04

Hard code ETH to be the base asset when using a mainnet fork

31bd92b

Skip chain-equality checks if using mainnet fork

bd75368

michalinacienciala mentioned this pull request May 29, 2023

Use fork in E2E tests of transactions #3418

Merged

4 tasks

michalinacienciala added 3 commits June 15, 2023 12:24

Merge remote-tracking branch 'origin/main' into mainnet-fork-triage

c4d3bac

Merge remote-tracking branch 'origin/main' into mainnet-fork-triage

d3a5140

michalinacienciala marked this pull request as ready for review June 15, 2023 10:47

michalinacienciala requested a review from a team as a code owner June 15, 2023 10:47

michalinacienciala self-assigned this Jun 15, 2023

michalinacienciala requested a review from Shadowfiend June 15, 2023 10:48

Shadowfiend reviewed Jun 15, 2023

View reviewed changes

Make ci/ an independent project

eefd477

This instead of a workspace in the top-level project. This allows the ci project to have its own dependencies, rather than polluting the lockfile for the top-level extension project with the large amount of hardhat dependencies.

Shadowfiend previously approved these changes Jun 16, 2023

View reviewed changes

Ignore ci for TypeScript purposes

03c998b

Shadowfiend dismissed their stale review via 03c998b June 16, 2023 17:46

Merge branch 'main' into mainnet-fork-triage

1bcb84b

Shadowfiend approved these changes Jun 16, 2023

View reviewed changes

Shadowfiend merged commit 5456a9c into main Jun 16, 2023

Shadowfiend deleted the mainnet-fork-triage branch June 16, 2023 18:04

jagodarybacka mentioned this pull request Jun 22, 2023

v0.39.0 #3496

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Hardhat Fork Functionality #3247

Add Hardhat Fork Functionality #3247

0xDaedalus commented Apr 4, 2023 •

edited by github-actions bot

Loading

Shadowfiend left a comment

Shadowfiend Jun 15, 2023

Shadowfiend Jun 15, 2023

Shadowfiend Jun 15, 2023

Shadowfiend Jun 15, 2023

Shadowfiend Jun 15, 2023

Shadowfiend left a comment

Shadowfiend commented Jun 16, 2023

Shadowfiend left a comment

Add Hardhat Fork Functionality #3247

Add Hardhat Fork Functionality #3247

Conversation

0xDaedalus commented Apr 4, 2023 • edited by github-actions bot Loading

Shadowfiend left a comment

Choose a reason for hiding this comment

Shadowfiend Jun 15, 2023

Choose a reason for hiding this comment

Shadowfiend Jun 15, 2023

Choose a reason for hiding this comment

Shadowfiend Jun 15, 2023

Choose a reason for hiding this comment

Shadowfiend Jun 15, 2023

Choose a reason for hiding this comment

Shadowfiend Jun 15, 2023

Choose a reason for hiding this comment

Shadowfiend left a comment

Choose a reason for hiding this comment

Shadowfiend commented Jun 16, 2023

Shadowfiend left a comment

Choose a reason for hiding this comment

0xDaedalus commented Apr 4, 2023 •

edited by github-actions bot

Loading