Auto-Not-So-Matic: Fix two matic.network URLs to polygon.technology #3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like matic.network has been fully decommissioned, and for both gas prices and for the PoS WETH asset, we were relying on it. Move to polygon.technology equivalents.
hyphenized
reviewed
Jun 16, 2023
There was a problem hiding this comment.
Works well, thought I had encountered a bug but it turns out that icon does not show up because we have a hardcoded icon for assets with the ETH symbol.
We can remove the dead code if we return an empty promise instead of modifying the stored collection in the migration. This shouldn't be a problem for 99% of our users given this would only affect users running anything before v0.18.0.
jagodarybacka
approved these changes
Jun 16, 2023
Merged
kkosiorowska
pushed a commit
that referenced
this pull request
Jun 21, 2023
## What's Changed * Auto-Not-So-Matic: Fix two matic.network URLs to polygon.technology by @Shadowfiend in #3483 **Full Changelog**: v0.38.0...v0.38.1 Latest build: [extension-builds-3484](https://github.com/tahowallet/extension/suites/13658282222/artifacts/754228230) (as of Fri, 16 Jun 2023 13:32:24 GMT).
Merged
jagodarybacka
added a commit
that referenced
this pull request
Jun 23, 2023
## What's Changed * Repeater Connection: Forward requests to new default when default is switched off during dApp connection flow by @Shadowfiend in #3462 * Auto-Not-So-Matic: Fix two matic.network URLs to polygon.technology by @Shadowfiend in #3483 * v0.38.0 by @kkosiorowska in #3480 * Case Dismissed: Forcibly show DAppConnectionInfoBar popover on first dApp connection by @Shadowfiend in #3464 * Add Hardhat Fork Functionality by @0xDaedalus in #3247 * Faded Jeans: Rename fadeIn class to fade_in by @Shadowfiend in #3485 * Fix issue for discovery transaction hash by @kkosiorowska in #3458 * Full Sweep: Drop the USE_UPDATED_SIGNING_UI feature flag by @Shadowfiend in #3475 * Token Discovery - Remap redux asset balances by @hyphenized in #3195 * Make specific warnings for adding custom asset by @kkosiorowska in #3478 * Run NFTs e2e tests on a controlled wallet address by @michalinacienciala in #3487 * v0.38.1 by @jagodarybacka in #3484 **Full Changelog**: v0.38.1...v0.39.0 Latest build: [extension-builds-3496](https://github.com/tahowallet/extension/suites/13792957673/artifacts/764738599) (as of Thu, 22 Jun 2023 14:27:32 GMT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like matic.network has been fully decommissioned, and for both gas prices and for the PoS WETH asset, we were relying on it. Move to polygon.technology equivalents.
In practice, the asset SVG for PoS WETH won't be used because newer versions of the Polygon token lists don't include the broken WETH asset that we were substituting in. We keep it because it's referenced in a migration and I would rather not try to figure out if it's safe to kill the migration for now.
Testing
Fixes #3482 .
Latest build: extension-builds-3483 (as of Fri, 16 Jun 2023 00:51:51 GMT).