Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change expected account name in NFTs tests to ENS domain #3494

Merged
merged 3 commits into from
Jun 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions e2e-tests/nfts.spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { wait } from "@tallyho/tally-background/lib/utils"
import { test, expect } from "./utils"
import { account1Address, account1Name } from "./utils/onboarding"

test.describe("NFTs", () => {
test("User can view nft collections, poaps and badges", async ({
Expand Down Expand Up @@ -36,9 +37,7 @@ test.describe("NFTs", () => {
}
})

await walletPageHelper.onboarding.addReadOnlyAccount(
"0x6f1b1f1feb01235e15a7962f16c389c7f8218ed6"
)
await walletPageHelper.onboarding.addReadOnlyAccount(account1Address)

await walletPageHelper.goToStartPage()
await walletPageHelper.setViewportSize()
Expand Down Expand Up @@ -80,7 +79,7 @@ test.describe("NFTs", () => {
await page
.getByTestId("nft_account_filters")
.filter({
hasText: /^(Phoenix|Matilda|Sirius|Topa|Atos|Sport|Lola|Foz)$/,
hasText: account1Name,
})
.getByRole("checkbox")
.click()
Expand All @@ -107,7 +106,7 @@ test.describe("NFTs", () => {
.getByTestId("nft_account_filters")
.getByTestId("toggle_item")
.filter({
hasText: /^(Phoenix|Matilda|Sirius|Topa|Atos|Sport|Lola|Foz)$/,
hasText: account1Name,
})
.getByRole("checkbox")
.click()
Expand Down
4 changes: 4 additions & 0 deletions e2e-tests/utils/onboarding.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ export const getOnboardingPage = async (
}

const DEFAULT_PASSWORD = "12345678"
// The account1 is a 3rd address associated with the testertesting.eth account.
// It owns some NFTs/badges.
export const account1Address = "0x6f1b1f1feb01235e15a7962f16c389c7f8218ed6"
export const account1Name = /^e2e\.testertesting\.eth$/

export default class OnboardingHelper {
constructor(
Expand Down