Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Opt] Identical store/load elimination by control-flow graph #1741

Merged
merged 4 commits into from
Aug 20, 2020

Conversation

xumingkuan
Copy link
Collaborator

@xumingkuan xumingkuan commented Aug 20, 2020

@xumingkuan xumingkuan changed the title [opt] Identical store/load elimination by control-flow graph [Opt] Identical store/load elimination by control-flow graph Aug 20, 2020
@xumingkuan xumingkuan marked this pull request as ready for review August 20, 2020 10:43
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #1741 into master will increase coverage by 0.98%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1741      +/-   ##
==========================================
+ Coverage   43.45%   44.44%   +0.98%     
==========================================
  Files          44       44              
  Lines        6015     5810     -205     
  Branches     1042     1042              
==========================================
- Hits         2614     2582      -32     
+ Misses       3250     3078     -172     
+ Partials      151      150       -1     
Impacted Files Coverage Δ
python/taichi/lang/ast_checker.py 70.58% <0.00%> (-1.64%) ⬇️
python/taichi/testing.py 77.41% <0.00%> (-0.71%) ⬇️
python/taichi/lang/linalg.py 89.33% <0.00%> (-0.67%) ⬇️
python/taichi/lang/meta.py 62.31% <0.00%> (-0.54%) ⬇️
python/taichi/lang/__init__.py 53.14% <0.00%> (-0.47%) ⬇️
python/taichi/misc/util.py 15.72% <0.00%> (-0.33%) ⬇️
python/taichi/misc/gui.py 0.00% <0.00%> (ø)
python/taichi/misc/task.py 0.00% <0.00%> (ø)
python/taichi/lang/shell.py 0.00% <0.00%> (ø)
python/taichi/tools/patterns.py 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44c459c...2af638d. Read the comment docs.

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

@yuanming-hu yuanming-hu merged commit 5548c55 into taichi-dev:master Aug 20, 2020
@xumingkuan xumingkuan deleted the identical-store-elim branch August 21, 2020 08:49
@yuanming-hu yuanming-hu mentioned this pull request Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants