Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt] Simplify identical load elimination #1782

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

xumingkuan
Copy link
Collaborator

Removes the warning introduced in #1741.

Benchmark (#statements): unchanged.

[Click here for the format server]


Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM. Thanks.

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #1782 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1782   +/-   ##
=======================================
  Coverage   42.60%   42.61%           
=======================================
  Files          44       44           
  Lines        6182     6183    +1     
  Branches     1071     1071           
=======================================
+ Hits         2634     2635    +1     
  Misses       3394     3394           
  Partials      154      154           
Impacted Files Coverage Δ
python/taichi/lang/kernel.py 71.03% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 139ff5d...865fef4. Read the comment docs.

@xumingkuan xumingkuan merged commit db426fe into taichi-dev:master Aug 27, 2020
@xumingkuan xumingkuan deleted the load branch August 29, 2020 09:57
@yuanming-hu yuanming-hu mentioned this pull request Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants