Only add type=button for real buttons
#709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). headlessui-react – ./packages/@headlessui-react🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/GJRcGAfyfZtzfTXBUbDaMcJRELMn headlessui-vue – ./packages/@headlessui-vue🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/37Wj7MELJHaAvqrXrq7yBY6bZYCm |
RobinMalfait
changed the title
{type:'button'} only for buttonstype=button for real buttons
RobinMalfait
force-pushed
the
resolve-button-type-correctly
branch
from
2c06ac9
to
4b508d3
Compare
We will try and infer the type based on the passed in `props.as` prop or
the default tag. However, when somebody uses `as={CustomComponent}` then
we don't know what it will render. Therefore we have to pass it a ref
and check if the final result is a button or not. If it is, and it
doesn't have a `type` yet, then we can set the `type` correctly.
RobinMalfait
force-pushed
the
resolve-button-type-correctly
branch
from
4b508d3
to
ab614c1
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We naively put
type: buttonon certain components because the default component is abutton. However, when somebody uses theasprop with a different component likediv, then adding a type of button results in weird/incorrect behaviour.This PR will check what the actual rendered DOM element is, and if it is a button without a type, only then will we apply a type of button.
Fixes: #619