Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only add type=button for real buttons #709

Merged
merged 2 commits into from
Aug 2, 2021
Merged

Only add type=button for real buttons #709

merged 2 commits into from
Aug 2, 2021

Commits on Aug 2, 2021

  1. add {type:'button'} only for buttons 

    We will try and infer the type based on the passed in `props.as` prop or
the default tag. However, when somebody uses `as={CustomComponent}` then
we don't know what it will render. Therefore we have to pass it a ref
and check if the final result is a button or not. If it is, and it
doesn't have a `type` yet, then we can set the `type` correctly.
    @RobinMalfait
    RobinMalfait committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    ab614c1 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @RobinMalfait
    RobinMalfait committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    d9cd3c4 View commit details
    Browse the repository at this point in the history