-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Rename core plugins to closer mirror CSS properties and modules #656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are you also planning on adding list style type utilities by any chance? :) |
Yeah I think I want to trash the whole |
Reverted the changes to Going to open a separate issue to discuss potential new names for the |
Note: This PR is only about changing the name of the core plugins themselves, not the classes generated by the core plugins. Even though the
leading
plugin will be renamed tolineHeight
, the classes it generates will still be.leading-{modifier}
.As part of 1.0 I want to make the core plugin names more consistent and guessable. After way too much deliberation I've decided it makes the most sense to stick with singular names, and match the CSS property (or module name) where possible.
For example,
fonts
will change tofontFamily
,backgroundColors
will change tobackgroundColor
,svgStroke
will change tostroke
, etc.Certain core plugins will continue to be responsible for multiple CSS properties, and those plugins will be named after the parent CSS module when possible. For example, the
flexbox
plugin will still be responsible foralign-items
,justify-content
,flex-direction
, etc., and in the future agrid
orgridLayout
plugin would likely be responsible for many of the CSS grid properties.Other core plugins may be split into multiple plugins in order to give them better names, like we may split
textStyle
into separatetextTransform
,textDecoration
,fontStyle
, andfontSmoothing
plugins (although we may not.)This is one of the biggest breaking changes for 1.0 but I think it's better than being stuck with a bunch of inconsistent names forever. This break will only affect your actual config file, and won't require making any changes in your actual HTML.
To Do:
backgroundColors
tobackgroundColor
borderColors
toborderColor
borderWidths
toborderWidth
fonts
tofontFamily
fontWeights
tofontWeight
Changeleading
tolineHeight
lists
tolistStyle
shadows
toboxShadow
svgFill
tofill
svgStroke
tostroke
textColors
tocolor
ortextColor
textSizes
tofontSize
textStyle
totextTransform
,textDecoration
,fontStyle
, andfontSmoothing
Changetracking
toletterSpacing