-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Rename tracking-* to letters-* #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think that I also wanted to note that if we decide to expand the number of values for letter-spacing, I would suggest not using a linear scale. Typography with very wide tracking is quite common in both print and web design, but you can only condense type so much before it begins to overlap. So negative values beyond a certain point cease to have any purpose. Therefore it would be best if the negative values scale much slower than the positive values. Something like this might work:
|
I think this is a great move. Only feedback is it would be cool if somehow letters and lines shared a convention for their prefix and sizes and was singular like the css property and existing css convention of letter word line
|
why no use
|
I still prefer the |
@sandren the post says why ls isn’t good. With spacing it’s not obvious what it’s spacing when you read it, could apply to anything that needs spacing. Letters words lines columns. |
Yeah not gonna use |
Good points, @dillingham and @adamwathan. Though I'm concerned that |
personally |
|
Decided to just leave everything as is, more here: #667 (comment) No point breaking people's sites for a class name change that I'm not even sure is actually better. |
This PR changes the name of our letter-spacing classes from
tracking-*
toletters-*
.tracking-tight
letters-tight
tracking-normal
letters-normal
tracking-wide
letters-wide
The motivation for this is the same as in #664. "Tracking" is not as well known in the web development world as "letter spacing" and since the CSS property is
letter-spacing
anyways I think it makes sense to stay closer to that.I considered
letter-spacing-*
andls-*
as potential names as well, butletter-spacing-*
is too long andls-*
is a bit too cryptic, as unlike line-height it's not quite as commonly used andls-*
could also meanlist-style
.I considered also switching to a numeric scale, but because of the negative values it's awkward (
letters--1
or-letters-1
). Using descriptive names liketight
andwide
is better in my opinion, and if necessary could be expanded withtightest
,tighter
,wider
, andwidest
, which should be plenty of options.This PR also changes the core plugin name from
tracking
toletterSpacing
, so letter-spacing values would be customized by editing theletterSpacing
key in the theme section of your config, and variants would be customized by editing theletterSpacing
key in the variants section of your config. This is in line with #656 and along with the class name change, and makes these settings more easily guessable.