Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made the docs better and fixed the port in validator systemd #147

Merged
merged 14 commits into from
Oct 4, 2023
Merged

Made the docs better and fixed the port in validator systemd #147

merged 14 commits into from
Oct 4, 2023

Conversation

Megumiiiiii
Copy link
Contributor

@Megumiiiiii Megumiiiiii commented Oct 4, 2023 •
edited
Loading

Summary of changes

Provide a detailed description of proposed changes.

  • Add copy buttons and labels to the code that needs to be copied
  • Fix port Validator systemd

Proposed area of change

Put an x in the boxes that apply.

  • Overview
  • Anchor System
  • dApps
  • Tangle
  • Protocols
  • Relayers

Code Checklist

  • I have tested that prove my changes are working as intended
  • I have added necessary documentation (if appropriate)

@netlify
Copy link

netlify bot commented Oct 4, 2023 •
edited
Loading

✅ Deploy Preview for development-webb-docs ready!

Name Link
🔨 Latest commit c027eb4
🔍 Latest deploy log https://app.netlify.com/sites/development-webb-docs/deploys/651d5045d530680008de4533
😎 Deploy Preview https://deploy-preview-147--development-webb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

1xstj
1xstj reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@1xstj 1xstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou! Looks great, just one minor nit

pages/docs/ecosystem-roles/validator/systemd/validator-node.mdx Show resolved Hide resolved
1xstj
1xstj approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@1xstj 1xstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thankyou @Megumiiiiii

@1xstj 1xstj merged commit ee6b6e9 into tangle-network:main Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1xstj 1xstj 1xstj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Megumiiiiii @1xstj