Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on macOS #157

Closed
ligurio opened this issue Apr 6, 2022 · 1 comment · Fixed by #268
Closed

Run tests on macOS #157

ligurio opened this issue Apr 6, 2022 · 1 comment · Fixed by #268
Assignees
@better0fdead
Labels
code health Improve code readability, simplify maintenance and so on

Comments

@ligurio
Copy link
Member

ligurio commented Apr 6, 2022

For declaring macOS support, we need to run tests on macOS. In this issue, we need to extend test environments in Github Actions with macOS.

Don't forget to add macOS as supported platform in th README.
@ligurio ligurio mentioned this issue Apr 6, 2022
Merged
@Totktonada Totktonada added teamE code health Improve code readability, simplify maintenance and so on labels Apr 6, 2022
@Totktonada
Copy link
Member

Consider an example of such CI job in the tarantool/smtp module. I guess we can just copy-paste it and adjust a bit.

@oleg-jukovec oleg-jukovec mentioned this issue Jul 1, 2022
Open
@LeonidVas LeonidVas assigned better0fdead and unassigned vr009 Nov 10, 2022
better0fdead added a commit that referenced this issue Nov 29, 2022
@better0fdead
ci: Add testing on macOS
316c5b6 
Added macOS testing into ci.

Closes #157
@better0fdead better0fdead mentioned this issue Nov 29, 2022
Closed
better0fdead added a commit that referenced this issue Nov 30, 2022
@better0fdead
ci: Add testing on macOS
97536f7 
Added macOS testing into ci.

Closes #157
better0fdead added a commit that referenced this issue Nov 30, 2022
@better0fdead
ci: switch to node16 runtime
48deb03 
Updated actions to versions with node16 runtime.

Follow up #157
better0fdead added a commit that referenced this issue Nov 30, 2022
@better0fdead
ci: switch to node16 runtime
61c6467 
Updated actions to versions with node16 runtime.

Follow up #157
better0fdead added a commit that referenced this issue Nov 30, 2022
@better0fdead
ci: Add testing on macOS
b7818f9 
Added macOS testing into ci.
Updated actions to versions with node16 runtime.

Closes #157
better0fdead added a commit that referenced this issue Dec 20, 2022
@better0fdead
ci: Add testing on macOS
b5834b8 
Added macOS testing into ci.
Updated actions to versions with node16 runtime.

Closes #157
better0fdead added a commit that referenced this issue Feb 7, 2023
@better0fdead
ci: Add testing on macOS
b002c1a 
Added macOS testing into ci.
Updated actions to versions with node16 runtime.

Closes #157
@better0fdead better0fdead mentioned this issue Feb 7, 2023
Merged
better0fdead added a commit that referenced this issue Feb 7, 2023
@better0fdead
ci: Add testing on macOS
dd00464 
Added macOS testing into ci.
Updated actions to versions with node16 runtime.

Closes #157
better0fdead added a commit that referenced this issue Feb 7, 2023
@better0fdead
test: fix connection_pool test
f911ace 
Changed checkTimeout time in test.

Part of #157
better0fdead added a commit that referenced this issue Feb 7, 2023
@better0fdead
test: fix TestUtube_Put test
4c3af3b 
Increased sleep duration. Added more checks.

Part of #157
better0fdead added a commit that referenced this issue Feb 7, 2023
@better0fdead
ci: Add testing on macOS
e60a663 
Added macOS testing into ci.
Updated actions to versions with node16 runtime.

Closes #157
better0fdead added a commit that referenced this issue Feb 7, 2023
@better0fdead
test: fix connection_pool test
ac2b672 
Changed checkTimeout time in test.

Part of #157
better0fdead added a commit that referenced this issue Feb 7, 2023
@better0fdead
test: fix TestUtube_Put test
81c8daf 
Increased sleep duration. Added more checks.

Part of #157
better0fdead added a commit that referenced this issue Feb 7, 2023
@better0fdead
ci: Add testing on macOS
872adab 
Added macOS testing into ci.
Updated actions to versions with node16 runtime.

Closes #157
better0fdead added a commit that referenced this issue Feb 7, 2023
@better0fdead
test: fix connection_pool test
d5f8c8f 
Changed checkTimeout time in test.

Part of #157
better0fdead added a commit that referenced this issue Feb 7, 2023
@better0fdead
test: fix TestUtube_Put test
157256d 
Increased sleep duration. Added more checks.

Part of #157
better0fdead added a commit that referenced this issue Feb 7, 2023
@better0fdead
ci: Add testing on macOS
7decb9d 
Added macOS testing into ci.
Updated actions to versions with node16 runtime.

Closes #157
better0fdead added a commit that referenced this issue Feb 7, 2023
@better0fdead
test: fix connection_pool test
e2142e9 
Changed checkTimeout time in test.

Part of #157
better0fdead added a commit that referenced this issue Feb 7, 2023
@better0fdead
test: fix TestUtube_Put test
4a82ce9 
Increased sleep duration. Added more checks.

Part of #157
better0fdead added a commit that referenced this issue Mar 16, 2023
@better0fdead
ci: Add testing on macOS
209da7a 
Added macOS testing into ci.
Updated actions to versions with node16 runtime.

Closes #157
better0fdead added a commit that referenced this issue Mar 16, 2023
@better0fdead
ci: add workaround for macOs-12
d88e048 
Added workaround for macOs-12 testrace.
Without it testrace sends SIGABRT after start.

Part of #157
better0fdead added a commit that referenced this issue Mar 16, 2023
@better0fdead
test: fix connection_pool test
67953e7 
Changed checkTimeout time in test.
The reason is that by default it updates the connects once every 1 second.
And it doesn't have time to update for some reason in the case of a test
 in the same second.
So set the update to half the time.

Part of #157
better0fdead added a commit that referenced this issue Mar 16, 2023
@better0fdead
test: fix TestUtube_Put test
c6b8e7e 
Increased sleep duration. Added more checks.

Part of #157
better0fdead added a commit that referenced this issue Mar 16, 2023
@better0fdead
ci: add workaround for macOs-12
af45d5d 
Added workaround for macOs-12 testrace.
Without it testrace sends SIGABRT after start.

Part of #157
better0fdead added a commit that referenced this issue Mar 16, 2023
@better0fdead
test: fix connection_pool test
c3c642a 
Changed checkTimeout time in test.
The reason is that by default it updates the connects once every 1 second.
And it doesn't have time to update for some reason in the case of a test
 in the same second.
So set the update to half the time.

Part of #157
better0fdead added a commit that referenced this issue Mar 16, 2023
@better0fdead
test: fix TestUtube_Put test
e755d1f 
Increased sleep duration. Added more checks.

Part of #157
better0fdead added a commit that referenced this issue Mar 16, 2023
@better0fdead
ci: Add testing on macOS
7cd0296 
Added macOS testing into ci.
Updated actions to versions with node16 runtime.

Closes #157
better0fdead added a commit that referenced this issue Mar 16, 2023
@better0fdead
ci: add workaround for macOs-12
d421394 
Added workaround for macOs-12 testrace.
Without it testrace sends SIGABRT after start.

Part of #157
better0fdead added a commit that referenced this issue Mar 16, 2023
@better0fdead
test: fix connection_pool test
aa9bbb6 
Changed checkTimeout time in test.
The reason is that by default it updates the connects once every 1 second.
And it doesn't have time to update for some reason in the case of a test
 in the same second.
So set the update to half the time.

Part of #157
better0fdead added a commit that referenced this issue Mar 16, 2023
@better0fdead
test: fix TestUtube_Put test
35d7326 
Increased sleep duration. Added more checks.

Part of #157
better0fdead added a commit that referenced this issue Mar 16, 2023
@better0fdead
ci: bump action version
31effa0 
Changed action version from 2 to 3.

Part of #157
better0fdead added a commit that referenced this issue Mar 16, 2023
@better0fdead
connection: fix codespell
c9ce4db 
Fixed codespell error.

Follow up #157
better0fdead added a commit that referenced this issue Mar 16, 2023
@better0fdead
ci: Add testing on macOS
887daf9 
Added macOS testing into ci.
Updated actions to versions with node16 runtime.

Closes #157
better0fdead added a commit that referenced this issue Mar 16, 2023
@better0fdead
ci: add workaround for macOs-12
6a662a9 
Added workaround for macOs-12 testrace.
Without it testrace sends SIGABRT after start.

Part of #157
better0fdead added a commit that referenced this issue Mar 16, 2023
@better0fdead
test: fix connection_pool test
9ceef86 
Changed checkTimeout time in test.
The reason is that by default it updates the connects once every 1 second.
And it doesn't have time to update for some reason in the case of a test
 in the same second.
So set the update to half the time.

Part of #157
better0fdead added a commit that referenced this issue Mar 16, 2023
@better0fdead
test: fix TestUtube_Put test
a9b4b13 
Increased sleep duration. Added more checks.

Part of #157
better0fdead added a commit that referenced this issue Mar 16, 2023
@better0fdead
ci: bump action version
cc73cc2 
Changed action version from 2 to 3.

Part of #157
better0fdead added a commit that referenced this issue Mar 24, 2023
@better0fdead
test: rewrite TestReconnect
5b333c2 
Rewrote TestReconnect.
Instead of just conn.Close() used stop the tarantool instance to
avoid auto-reconnect. Restarted it after. Added checks.

Part of #157
better0fdead added a commit that referenced this issue Mar 24, 2023
@better0fdead
test: fix TestTtlQueue
34a606e 
Changed sleep duration time in test.
The reason is that ttl time is set to 5 seconds in test.
And it doesn't have time for some reason in the case of a test in
the same time.
So set the sleep duration to 10 seconds.

Part of #157
better0fdead added a commit that referenced this issue Mar 24, 2023
@better0fdead
test: rewrite TestReconnect
dc1b297 
Rewrote TestReconnect.
Instead of just conn.Close() used stop the tarantool instance to
avoid auto-reconnect. Restarted it after. Added checks.

Part of #157
better0fdead added a commit that referenced this issue Mar 24, 2023
@better0fdead
test: fix TestTtlQueue
c76da2f 
Changed sleep duration time in test.
The reason is that ttl time is set to 5 seconds in test.
And it doesn't have time for some reason in the case of a test in
the same time.
So set the sleep duration to 10 seconds.

Part of #157
oleg-jukovec pushed a commit that referenced this issue Mar 24, 2023
@better0fdead @oleg-jukovec
ci: Add testing on macOS
fbe0470 
Added macOS testing into ci.
Updated actions to versions with node16 runtime.

Closes #157
oleg-jukovec pushed a commit that referenced this issue Mar 24, 2023
@better0fdead @oleg-jukovec
ci: add workaround for macOs-12
8ae485f 
Added workaround for macOs-12 testrace.
Without it testrace sends SIGABRT after start.

Part of #157
oleg-jukovec pushed a commit that referenced this issue Mar 24, 2023
@better0fdead @oleg-jukovec
test: fix connection_pool test
b6bfb4b 
Changed checkTimeout time in test.
The reason is that by default it updates the connects once every 1 second.
And it doesn't have time to update for some reason in the case of a test
 in the same second.
So set the update to half the time.

Part of #157
oleg-jukovec pushed a commit that referenced this issue Mar 24, 2023
@better0fdead @oleg-jukovec
test: fix TestUtube_Put test
cf224ce 
Increased sleep duration. Added more checks.

Part of #157
oleg-jukovec pushed a commit that referenced this issue Mar 24, 2023
@better0fdead @oleg-jukovec
ci: bump action version
4c6be30 
Changed action version from 2 to 3.

Part of #157
oleg-jukovec pushed a commit that referenced this issue Mar 24, 2023
@better0fdead @oleg-jukovec
test: rewrite TestReconnect
8c35168 
Rewrote TestReconnect.
Instead of just conn.Close() used stop the tarantool instance to
avoid auto-reconnect. Restarted it after. Added checks.

Part of #157
oleg-jukovec pushed a commit that referenced this issue Mar 24, 2023
@better0fdead @oleg-jukovec
test: fix TestTtlQueue
888d74d 
Changed sleep duration time in test.
The reason is that ttl time is set to 5 seconds in test.
And it doesn't have time for some reason in the case of a test in
the same time.
So set the sleep duration to 10 seconds.

Part of #157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@better0fdead better0fdead

Labels
code health Improve code readability, simplify maintenance and so on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Add testing on macOS tarantool/go-tarantool
ci: Add testing on macOS tarantool/go-tarantool
4 participants
@Totktonada @ligurio @vr009 @better0fdead