ci: Add testing on macOS #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
better0fdead
force-pushed
the
better0fdead/gh-157-macos
branch
3 times, most recently
from
4c3af3b
to
81c8daf
Compare
oleg-jukovec
requested changes
Feb 7, 2023
better0fdead
force-pushed
the
better0fdead/gh-157-macos
branch
2 times, most recently
from
157256d
to
4a82ce9
Compare
better0fdead
force-pushed
the
better0fdead/gh-157-macos
branch
6 times, most recently
from
e755d1f
to
31effa0
Compare
Added macOS testing into ci. Updated actions to versions with node16 runtime. Closes #157
Added workaround for macOs-12 testrace. Without it testrace sends SIGABRT after start. Part of #157
Changed checkTimeout time in test. The reason is that by default it updates the connects once every 1 second. And it doesn't have time to update for some reason in the case of a test in the same second. So set the update to half the time. Part of #157
Increased sleep duration. Added more checks. Part of #157
Changed action version from 2 to 3. Part of #157
better0fdead
force-pushed
the
better0fdead/gh-157-macos
branch
from
c9ce4db
to
cc73cc2
Compare
oleg-jukovec
requested changes
Mar 16, 2023
There was a problem hiding this comment.
I see a flaky test on macOS:
2023-03-16T14:18:05.7459090Z --- FAIL: TestReconnect (0.62s)
2023-03-16T14:18:05.7567240Z multi_test.go:108: conn has incorrect addr: 127.0.0.1:3013 after disconnect server1
I think you need to make a change in TestReconnect similar too:
- Stop the tarantool instance instead of just conn.Close() to avoid auto-reconnects.
- Ensure that the connection is gone from a connection pool (in a loop with N retries with a little delay between iterations).
- Restart the instance.
- Ensure that the connection is available for requests (in a loop with N retries with a little delay between iterations).
better0fdead
force-pushed
the
better0fdead/gh-157-macos
branch
3 times, most recently
from
d474a64
to
34a606e
Compare
multi/multi_test.go
Outdated
| if !ok { | ||
| break | ||
| } | ||
| multiConn.getState() |
There was a problem hiding this comment.
Suggested change
| multiConn.getState() |
oleg-jukovec
approved these changes
Mar 24, 2023
Rewrote TestReconnect. Instead of just conn.Close() used stop the tarantool instance to avoid auto-reconnect. Restarted it after. Added checks. Part of #157
Changed sleep duration time in test. The reason is that ttl time is set to 5 seconds in test. And it doesn't have time for some reason in the case of a test in the same time. So set the sleep duration to 10 seconds. Part of #157
better0fdead
force-pushed
the
better0fdead/gh-157-macos
branch
from
34a606e
to
c76da2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added macOS testing into ci.
Closes #157