test: fix execution with Tarantool 1.6 #198
Conversation
oleg-jukovec
force-pushed
the
oleg-jukovec/ci-tnt-1.6
branch
2 times, most recently
from
8590796 to
1119547
Compare
|
As an alternative way we can update the README.md and start to support Tarantool 1.10+ |
Despite the fact that queue requires Tarantool 1.7 [1] it uses features from Tarantool 1.7.4. `box.info.ro` [2] as an example. The same for connection_pool. The patch disables tests execution for queue and connection_pool with Tarantool < 1.7.4. 1. https://github.com/tarantool/queue/blob/master/rpm/tarantool-queue.spec#L10 2. tarantool/tarantool@56462bc
We still support Tarantool 1.6, so we need to use Call16 by default.
The patch fixes tests execution results with Tarantool 1.6.
Tarantool 1.6.9 cannot be installed from a ready package, so we need to build it manually.
oleg-jukovec
force-pushed
the
oleg-jukovec/ci-tnt-1.6
branch
from
1119547 to
af36e9b
Compare
| @@ -187,7 +187,7 @@ func (connMulti *ConnectionMulti) checker() { | |||
| continue | |||
| } | |||
| var resp [][]string | |||
| err := connMulti.Call17Typed(connMulti.opts.NodesGetFunctionName, []interface{}{}, &resp) | |||
| err := connMulti.Call16Typed(connMulti.opts.NodesGetFunctionName, []interface{}{}, &resp) | |||
There was a problem hiding this comment.
It is not a strict equivalent, see tarantool/tarantool-java#196.
| var tuples3 [][]Tuple3 | ||
| err = conn.Call17Typed("func_name", []interface{}{}, &tuples3) | ||
| var tuples3 []Tuple3 | ||
| err = conn.Call16Typed("func_name", []interface{}{}, &tuples3) |
There was a problem hiding this comment.
What I really don't like about CALL_16: it implicitly changes a shape of the result (and the rules are not very obvious). Personally I would avoid it as much as possible. Or at least call only those functions, which return exactly what we'll receive on the connector side: so it will not be wrapped into an array or unwrapped. Maybe skipping of some tests is not so evil as pollute them with CALL_16.
I don't insist, just share my feeling about this.
| - name: Build Tarantool ${{ matrix.tarantool }} | ||
| if: matrix.tarantool == '1.6.9' && steps.cache-tnt-build.outputs.cache-hit != 'true' | ||
| run: | | ||
| sudo apt-get -y install git build-essential cmake make zlib1g-dev \ | ||
| libreadline-dev libncurses5-dev libssl-dev \ | ||
| libunwind-dev libicu-dev python3 python3-yaml \ | ||
| python3-six python3-gevent | ||
| cd ${GITHUB_WORKSPACE}/tarantool | ||
| mkdir build && cd build | ||
| cmake .. -DCMAKE_BUILD_TYPE=Release | ||
| make | ||
| make DESTDIR=${TNT_BUILD_INSTALL_PATH} install |
There was a problem hiding this comment.
Wow. I would do the following instead:
- Build the package once for Ubuntu Focal.
- Agree with @LeonidVas and @artembo where to place such special packages.
- Optionally add support for setup-tarantool.
I don't insist: if it works, it is likely okay. However we can do it a bit better (faster, more durable, less code).
In practical terms, nothing prevent us from support only 1.10+. OTOH, 1.6.9 support don't add much problems. I'm okay with any solution here. |
|
We should explicitly switch to support only 1.10+. If users are not ready to update Tarantool, let them take an older version of the connector. |
|
It was decided to make another pull request with switch to support only 1.10+ (README.md, comments). |
Technically, the connector can now work with Tarantool 1.6+. But we decided to simplify our CI and do not declare support for older versions [1]. 1. #198
Technically, the connector can now work with Tarantool 1.6+. But we decided to simplify our CI and do not declare support for older versions [1]. 1. #198
We declare support of Tarantool 1.6 in README.md:
go-tarantool/README.md
Lines 14 to 15 in 4b066ae
go-tarantool/README.md
Lines 34 to 35 in 4b066ae
It would be great for the tests to work with Tarantool 1.6.
The patch fixes the tests and adds run with Tarantool 1.6.9 to GitHub Actions.
I didn't forget about (remove if it is not applicable):