-
Notifications
You must be signed in to change notification settings - Fork 19
cluster discovery: discard non-list result #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We can only fix docs here, I think. |
'host' is a4686f7374, {'host'} is 91a4686f7374. If they are really undistinguishable, it is something strange on the connector side. |
Instead of discarding the full list of addresses when at least one address does not match the format like host[:port] a discoverer just skips this broken address and carries on processing. Change discovery function requirements description in part of single value support. This is done to be consistent with other Tarantool connectors. Closes: #195, #196
hm... It seems Lua returns an array in both cases |
That is so. We should newer use call_16, tarantool-1.6 is gone a long time ago. It seems we can remove it entirely. |
Instead of discarding the full list of addresses when at least one address does not match the format like host[:port] a discoverer just skips the broken address and carries on processing. Discard a single string return type for a cluster discovery function. Change discovery function requirements in part of single value support. This is done to be consistent with other Tarantool connectors. Closes: #195, #196
Instead of discarding the full list of addresses when at least one address does not match the format like host[:port] a discoverer just skips the broken address and carries on processing. Discard a single string return type for a cluster discovery function. Change discovery function requirements in part of single value support. This is done to be consistent with other Tarantool connectors. Closes: #195, #196
Instead of discarding the full list of addresses when at least one address does not match the format like host[:port] a discoverer just skips the broken address and carries on processing. Discard a single string return type for a cluster discovery function. Change discovery function requirements in part of single value support. This is done to be consistent with other Tarantool connectors. Closes: #195, #196
The call_16 became obsolete when tarantool-1.6 was gone. There're no reasons to continue using the old version by default. Change discovery function requirements in part of single value support. This is done to be consistent with other Tarantool connectors. Closes: #196
The call_16 became obsolete when tarantool-1.6 was gone. There're no reasons to continue using the old version by default. Change discovery function requirements in part of single value support. This is done to be consistent with other Tarantool connectors. Closes: tarantool#196
From README:
I think there is no reason to support single string result. However if we'll support it here it will push other connectors to support it too (because a user that see correct result with tarantool-java will expect they will be correct with another connector too).
I propose to forbid support of this single string response format and allow only a list of strings result.
Validation rules and to be defined and maybe should be strictier that now and consistent with other connectors. Maybe this should not be handled with the scope of this issue.
The text was updated successfully, but these errors were encountered: