Socket provider retry policy #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktorwald
force-pushed
the
nicktorwald/gh-167-socket-provider-timeout
branch
2 times, most recently
from
6745179 to
dcf562b
Compare
Totktonada
reviewed
May 13, 2019
nicktorwald
force-pushed
the
nicktorwald/gh-167-socket-provider-timeout
branch
2 times, most recently
from
8084884 to
fe6bdbb
Compare
Totktonada
reviewed
May 14, 2019
Totktonada
reviewed
May 14, 2019
|
I give minor comments, but the PR is okay for me in general. @akudiyar Can you check the README changes and approve that the new timeout / retry strategy is okay for you? |
nicktorwald
changed the title
nicktorwald
force-pushed
the
nicktorwald/gh-167-socket-provider-timeout
branch
from
fe6bdbb to
f960c18
Compare
Relax a socket provider contract. Now socket provider can throw a transient error and the client will try to obtain a socket again instead of being closed. Make built-in socket providers configurable. Now the client can set retries count and connection timeout for providers. Update README doc im scope of new socket provider contract. Closes: #167 Follows on: #144
nicktorwald
force-pushed
the
nicktorwald/gh-167-socket-provider-timeout
branch
from
f960c18 to
9729f0b
Compare
|
@Totktonada all changes are OK |
Totktonada
reviewed
May 16, 2019
Totktonada
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax a socket provider contract. Now socket provider can throw a
transient error and the client will try to obtain a socket again instead
of being closed.
Make built-in socket providers configurable. Now the client can set
retries count and connection timeout for providers.
Update README doc im scope of new socket provider contract.
Closes: #167
Follows on: #144