Introduce Tarantool client DSL #247
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktorwald
changed the title
nicktorwald
force-pushed
the
nicktorwald/gh-212-request-dsl
branch
from
c06f6a9 to
63f1dee
Compare
This DSL includes set of request builders that can be used as a public API to construct requests. The main idea here is to provide more natural DSL-like approach to build operations instead of current abstract types like List<?> or List<Object>. Closes: #212
nicktorwald
force-pushed
the
nicktorwald/gh-212-request-dsl
branch
from
63f1dee to
45e4b39
Compare
Totktonada
reviewed
Apr 28, 2020
| ops.upsert(512, Collections.singletonList(3), Arrays.asList(3, "KAMAZ-65224", 65), Arrays.asList("=", 2, 65)); | ||
| ops.upsert("cars", Collections.singletonList(3), Arrays.asList(3, "KAMAZ-65224", 65), Arrays.asList("=", 2, 65)); | ||
| ops.execute( | ||
| upsertRequest("cars", Collections.singletonList(3), assign(2, 65)) |
There was a problem hiding this comment.
Collections.singletonList(3) → Arrays.asList(3, "KAMAZ-65224", 65)?
|
@akudiyar, can you look into the API? |
Shared my thoughts in the PR with the superset of changes -- #223 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce Tarantool client DSL
This DSL includes set of request builders that can be used as a public
API to construct requests. The main idea here is to provide more
natural DSL-like approach to build operations instead of current
abstract types like List<?> or List.
Closes: #212