add round robin fail-over for a client #98
Conversation
There was a problem hiding this comment.
Thanks for the patch!
I proposed some fixes on the add-round-robin-reconnect-strategy-fixups branch and leave some comments below.
There is unclear thing for me: I got failures with your RetryingClient implementation, while it seems this should not happen. I worked it around, but of course it should be investigated further (at least to understand what is going on).
ztarvos
force-pushed
the
add-round-robin-reconnect-strategy
branch
from
31a3b89 to
17a941a
Compare
There was a problem hiding this comment.
The PR looks good to me.
I merged #99 recently and this PR need to be rebased. I made it on the add-round-robin-reconnect-strategy-rebased branch: resolved trivial conflicts within the rebased commit and added the commit with changes I want you to see (I don't sure whether I did good thing around generics).
Added cluster-ready client implementation that would fail-over to the next configured server in a round-robin fashion. Closes tarantool#37
ztarvos
force-pushed
the
add-round-robin-reconnect-strategy
branch
from
17a941a to
cf16d5c
Compare
|
I only noticed one missing |
Added socket channel provider implementation that
would fail-over to the next configured server in a
round-robin fashion.
Closes #37