Initial JDBC support #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totktonada
force-pushed
the
connector-1.8.jdbc-rebased
branch
5 times, most recently
from
b4e37f9 to
1e0d349
Compare
Cleanup the directory once before all tests: move it from the TarantoolControl constructor to the static block.
It fixes race conditions in testLongParallelCloseReconnects: an attempt to start jdk-testing instance against already started one could be performed because stopTarantool() did not wait until an instance will really stop. Use these functions in setupEnv() / cleanupEnv() to avoid possible race conditions.
Updated constants to be in sync with tarantool IPROTO. Added integration tests for the working JDBC functionality. Fixed travis script to use tarantool 2.0 which is required for SQL. Fixed failing user permission calls in tarantool initialization script. Closes #39 ---- Rebase fixes (Alexander Turenko): * Start tarantool from the Java code in JDBC tests (use TarantoolControl).
Fixed several mistakes in get primary keys metadata API. Corrected type mismatch when parsing server response. Added sorting of result rows by column name. Fixed order of columns in result set. Wrapped errors into SQLException. Improved test coverage. Closes #41 ---- Rebase fixes (Alexander Turenko): * Start / stop jdk-testing instance using TarantoolControl in JdbcExceptionHandlingTest.
Fixed exception when packing date/time parameters of prepared statement. Added test for parameter binding methods. Closes #43
Added connection property `socketTimeout` to allow user control over network timeout before actual connection is returned by the driver. This is only done for default socket provider. The default timeout is left to be infinite. Implemented `Connection.setNetworkTimeout` API to make it possible to change the maximum amount of time to wait for server replies after the connection is established. The connection that has timed out is forced to close. New subsequent operations requested on such connection must fail right away. The corresponding checks are embedded into relevant APIs. Closes #38
Totktonada
force-pushed
the
connector-1.8.jdbc-rebased
branch
from
1e0d349 to
a83801f
Compare
|
Removed implicit test directory cleanup between tests: 292671e. Fixed flaky CI fails on testLongParallelCloseReconnects: a588557. Used TarantoolControl in the JDBC tests (see changed commit messages). @dgreenru Says he cannot see the PR for now, but blindly okay with the merge. @ztarvos I’m waiting for your comments. |
ztarvos
reviewed
Dec 13, 2018
There was a problem hiding this comment.
@Totktonada, I have just one comment regarding the changes in JdbcExceptionHandlingTest.java.
Otherwise, LGTM. Thank you.
src/test/java/org/tarantool/jdbc/JdbcExceptionHandlingTest.java
Outdated
Show resolved
Hide resolved
It is needed to get rid of having tarantool connection in the unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.