Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: update test/integration/connect/test_connect.py #956

Closed
dmyger opened this issue Sep 25, 2024 · 0 comments · Fixed by #958
Closed

tests: update test/integration/connect/test_connect.py #956

dmyger opened this issue Sep 25, 2024 · 0 comments · Fixed by #958
Assignees
Labels
1sp code health Improve code readability, simplify maintenance and so on

Comments

@dmyger
Copy link
Collaborator

dmyger commented Sep 25, 2024

Ensure that the stop_app() is called regardless of the success or failure of the tests.

@dmyger dmyger self-assigned this Sep 25, 2024
@oleg-jukovec oleg-jukovec added 1sp code health Improve code readability, simplify maintenance and so on labels Sep 25, 2024
dmyger added a commit that referenced this issue Sep 25, 2024
Wrap call `start_app` & `stop_app` in try/finally blocks. Modified code was auto reformatted, also.

Closes #956
dmyger added a commit that referenced this issue Sep 30, 2024
Wrap call `start_app` & `stop_app` in try/finally blocks. Modified code was auto reformatted, also.

Closes #956
dmyger added a commit that referenced this issue Oct 1, 2024
Wrap call `start_app` & `stop_app` in try/finally blocks. Modified code was auto reformatted, also.

Closes #956
dmyger added a commit that referenced this issue Oct 3, 2024
Wrap call `start_app` & `stop_app` in try/finally blocks. Modified code was auto reformatted, also.

Closes #956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1sp code health Improve code readability, simplify maintenance and so on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants