test: update test_connect to use stop_app #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
The error occurs in test_connect: https://github.com/tarantool/tt/actions/runs/11032062834/job/30640120785?pr=958#step:7:47
|
Please, rebase the pull request. |
dmyger
force-pushed
the
dmyger/gh-956-update-test_connect_py
branch
4 times, most recently
from
c7c5712
to
4d5cf10
Compare
oleg-jukovec
approved these changes
Oct 2, 2024
themilchenko
approved these changes
Oct 2, 2024
Wrap call `start_app` & `stop_app` in try/finally blocks. Modified code was auto reformatted, also. Closes #956
dmyger
force-pushed
the
dmyger/gh-956-update-test_connect_py
branch
from
4d5cf10
to
140bb35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap call
start_app&stop_appin try/finally blocks. Modified code was auto reformatted, also.Closes #956