replicaset: soften name validation #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During upgrade to Tarantool 3.0.0 there's a time, when instance name
have not been set yet. If vshard strictly validates names on connection,
it leads to the cluster unavailability by the time, when all names are
configured.
This commit softens the check and allows name to be nil, when instance
UUID is specified in configuration, only UUID is validated in such case.
In conclusion we have the following checks on connection:
1. UUID is validated in the following cases:
a. When `identification_mode` is `uuid_as_key`
b. When `identification_mode` is `name_as_key` and replica.uuid
is specified
2. Instance name is validated only when `identification_mode` is
`name_as_key` and can work in the following modes:
a. Strict validation (nil instance name is not allowed), when
replica.uuid is not specified.
b. Soft validation (nil instance name is allowed), when
replica.uuid is specified.
Follow-up tarantool#426
NO_DOC=internal
Gerold103
approved these changes
Dec 20, 2023
Serpentian
added a commit
to Serpentian/tarantool
that referenced
this pull request
Dec 21, 2023
This commit adds a test, that covers the integration of tarantool's config module with vshard and verifies correctness of changes in tarantool#9514 and tarantool/vshard#458. It checks, that we're able to upgrade several vshard clusters without downtime. NO_DOC=test NO_CHANGELOG=test
Serpentian
added a commit
to Serpentian/tarantool
that referenced
this pull request
Dec 21, 2023
This commit adds a test, that covers the integration of tarantool's config module with vshard and verifies correctness of changes in tarantool#9514 and tarantool/vshard#458. It checks, that we're able to upgrade several vshard clusters without downtime. NO_DOC=test NO_CHANGELOG=test
Serpentian
added a commit
to Serpentian/tarantool
that referenced
this pull request
Dec 26, 2023
This commit adds a test, that covers the integration of tarantool's config module with vshard and verifies correctness of changes in tarantool#9514 and tarantool/vshard#458. It checks, that we're able to upgrade several vshard clusters without downtime. NO_DOC=test NO_CHANGELOG=test
Serpentian
added a commit
to Serpentian/tarantool
that referenced
this pull request
Feb 2, 2024
This commit adds a test, that covers the integration of tarantool's config module with vshard and verifies correctness of changes in tarantool#9514 and tarantool/vshard#458. It checks, that we're able to upgrade several vshard clusters without downtime. NO_DOC=test NO_CHANGELOG=test
Serpentian
added a commit
to Serpentian/tarantool
that referenced
this pull request
Feb 2, 2024
This commit adds a test, that covers the integration of tarantool's config module with vshard and verifies correctness of changes in tarantool#9514 and tarantool/vshard#458. It checks, that we're able to upgrade several vshard clusters without downtime. NO_DOC=test NO_CHANGELOG=test
Serpentian
added a commit
to Serpentian/tarantool
that referenced
this pull request
Feb 2, 2024
This commit adds a test, that covers the integration of tarantool's config module with vshard and verifies correctness of changes in tarantool#9514 and tarantool/vshard#458. It checks, that we're able to upgrade several vshard clusters without downtime. NO_DOC=test NO_CHANGELOG=test
Serpentian
added a commit
to Serpentian/tarantool
that referenced
this pull request
Feb 2, 2024
This commit adds a test, that covers the integration of tarantool's config module with vshard and verifies correctness of changes in tarantool#9514 and tarantool/vshard#458. It checks, that we're able to upgrade several vshard clusters without downtime. NO_DOC=test NO_CHANGELOG=test
Totktonada
pushed a commit
to tarantool/tarantool
that referenced
this pull request
Feb 6, 2024
This commit adds a test, that covers the integration of tarantool's config module with vshard and verifies correctness of changes in #9514 and tarantool/vshard#458. It checks, that we're able to upgrade several vshard clusters without downtime. NO_DOC=test NO_CHANGELOG=test
Totktonada
pushed a commit
to Totktonada/tarantool
that referenced
this pull request
Feb 6, 2024
This commit adds a test, that covers the integration of tarantool's config module with vshard and verifies correctness of changes in tarantool#9514 and tarantool/vshard#458. It checks, that we're able to upgrade several vshard clusters without downtime. NO_DOC=test NO_CHANGELOG=test (cherry picked from commit 9e9ea6d)
Totktonada
pushed a commit
to tarantool/tarantool
that referenced
this pull request
Feb 7, 2024
This commit adds a test, that covers the integration of tarantool's config module with vshard and verifies correctness of changes in #9514 and tarantool/vshard#458. It checks, that we're able to upgrade several vshard clusters without downtime. NO_DOC=test NO_CHANGELOG=test (cherry picked from commit 9e9ea6d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During upgrade to Tarantool 3.0.0 there's a time, when instance name have not been set yet. If vshard strictly validates names on connection, it leads to the cluster unavailability by the time, when all names are configured.
This commit softens the check and allows name to be nil, when instance UUID is specified in configuration, only UUID is validated in such case.
In conclusion we have the following checks on connection:
Follow-up #426
NO_DOC=internal