Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replicaset: soften name validation #458

Merged
merged 1 commit into from
Dec 20, 2023

Commits on Dec 20, 2023

  1. replicaset: soften name validation

    During upgrade to Tarantool 3.0.0 there's a time, when instance name
    have not been set yet. If vshard strictly validates names on connection,
    it leads to the cluster unavailability by the time, when all names are
    configured.
    
    This commit softens the check and allows name to be nil, when instance
    UUID is specified in configuration, only UUID is validated in such case.
    
    In conclusion we have the following checks on connection:
    
        1. UUID is validated in the following cases:
            a. When `identification_mode` is `uuid_as_key`
            b. When `identification_mode` is `name_as_key` and replica.uuid
               is specified
    
        2. Instance name is validated only when `identification_mode` is
           `name_as_key` and can work in the following modes:
            a. Strict validation (nil instance name is not allowed), when
               replica.uuid is not specified.
            b. Soft validation (nil instance name is allowed), when
               replica.uuid is specified.
    
    Follow-up tarantool#426
    
    NO_DOC=internal
    Serpentian committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    83cb025 View commit details
    Browse the repository at this point in the history