-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Using Mamba in Pipelines #1210
Conversation
Looks like I have to add mamba to PATH. |
I think the problem is you're calling |
Remember the |
Codecov Report
@@ Coverage Diff @@
## master #1210 +/- ##
==========================================
+ Coverage 77.71% 80.63% +2.91%
==========================================
Files 91 41 -50
Lines 5727 3424 -2303
==========================================
- Hits 4451 2761 -1690
+ Misses 1276 663 -613 Continue to review full report at Codecov.
|
displayName: Add conda to PATH | ||
|
||
- bash: | | ||
sudo chown -R $USER $CONDA | ||
# conda update -y conda | ||
sudo chown -R $USER $CONDA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split this step in two steps. The first one does the chown
thing and must run exclusive for macOS. The second one does the update, but comment it out because we don't use that unless is necessary.
displayName: "TARDIS test" | ||
|
||
- script: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use bash
instead of script
.
displayName: "Install TARDIS env" | ||
|
||
- bash: | | ||
sh ci-helpers/fetch_reference_data.sh | ||
# sh ci-helpers/fetch_reference_data.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all the comments and the last cd
line.
@@ -65,6 +65,7 @@ jobs: | |||
git lfs pull --include="atom_data/chianti_He.h5" origin | |||
git lfs pull --include="plasma_reference/" origin | |||
git lfs pull --include="unit_test_data.h5" origin | |||
git lfs pull --include="packet_unittest.h5" origin | |||
echo MD5 `md5sum unit_test_data.h5` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a colon after MD5
Added a step to fail build on error as suggested by epassaro improved documentation to steps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify: the bandwith of GitHub LFS is limited, so we must save as much as we can. And yes, it's faster.
Also try to roll back the changes in both helpers scripts, since we are not using them anymore. Probably will be deleted in the future.
I made some changes to the fetch refdata bash script. Probably is the one we will keep, the other two files are not needed anymore. Keep only the changes in the YAML file in this PR. |
* testing mamba installation. Simply install mamba from conda and try to create env * added mamba after conda installation * check if mamba installation succesful * installing mamba before activating * fix syntax errors * Pin mamba to 0.4.0 and make pipelines exit on error with any bash command * move tardis_env.sh into pipelines file * fetch reference data fetching from bash scripts to azure pipelines file * fix syntax error * Added packet data * Adding variable shellopts to check * added shellopts=errexit so that build fails on non-zero error code * testing if pipeline fails * reverting changes, testing succesful * remove unused lines * testing, this should fail the pipeline * Made all single lines where necessary Added a step to fail build on error as suggested by epassaro improved documentation to steps * added back the git lfs pull code * removed git lfs codes * added git lfs to pipelines to make it faster
Do not merge this PR, this is a WIP. Checking if mamba installation is successful on the Azure pipelines.