Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for reference data pipeline #1242

Closed
wants to merge 40 commits into from

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Jul 18, 2020

Motivation

Description

  • Use already existing ci-helpers/fetch_reference_data.sh script to save LFS bandwith.
  • Small changes to ci-helpers/fetch_reference_data.sh script.
  • Add bash exit step on failure.
  • Add a variable to choose between mamba and conda package managers.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have assigned/requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Jul 18, 2020

Codecov Report

Merging #1242 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1242   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          41       41           
  Lines        3424     3424           
=======================================
  Hits         2761     2761           
  Misses        663      663           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56f6acd...f85ba93. Read the comment docs.

@epassaro epassaro marked this pull request as draft July 19, 2020 00:19
@epassaro epassaro closed this Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant