-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes to I/O documentation #1660
Conversation
Before a pull request is accepted, it must meet the following criteria:
|
Codecov Report
@@ Coverage Diff @@
## master #1660 +/- ##
=======================================
Coverage 61.89% 61.89%
=======================================
Files 62 62
Lines 5732 5732
=======================================
Hits 3548 3548
Misses 2184 2184 Continue to review full report at Codecov.
|
@smithis7 can you rebase? |
I did a merge commit (I'm still working on getting good at rebasing) but I solved the conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just have few additional suggestions that are related to this PR
38f7727
to
c93d3da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
* adding missing info in config docs * added callback and vpacket logging output docs [build docs] * Jaladh's suggested changes * Corrected typo
This is a follow up to my pull requests restructuring the documentation which ties up some loose ends in the I/O documentation.
Description
Changes include:
How has this been tested?
Examples
View the built documentation here:
https://smithis7.github.io/tardis/branch/io-quick-fixes/
Type of change
Checklist