fix file url for enterprise #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koshry Report
|
Koshry Report
|
Koshry Report
|
tarek360
added a commit
that referenced
this pull request
Nov 18, 2018
* introduce JacocoCoverageRule (#6) * introduce JacocoCoverageRule * add JacocoCoverageRuleTest * support all nested objects * improve test coverage * add more tests * make issue levels take text (#8) * config bintray * convert the Rule to abstract class (#7) * convert the Rule to abstract class * fix push.gradle * auto release (#9) * auto release * add release task to circle ci * add ci and pullRequest to Rule (#10) * add ci and pullRequest to Rule * fix test * exclude some authors from protected files rule (#11) * jacoco total coverage (#12) * introduce Github-enterprise (#15) * Unify dependencies versions by applying buildSrc (#14) * Making unify dependencies versions feature by applying buildSrc mechanism and Gradle DSL then change all the build.gradle.kts files of all the modules we have to be use the new kotlin class that I made. Since four classes are made : 1. Dependencies : that contains all the dependencies we will use. 2. MainApp : that contains the common things of the whole app. 3. MainClass : that contains the main classes of each module. 4. Projects : that contains the name of projects/modules we have tell now. 5. Versions : that contains the versions that we will use in Dependencies class. * Modify Naming of buildSrc files - Projects file renamed to Modules to be more meaningful. - MainApp file renamed to Project to be more specific. * fix file url for enterprise (#18) * fix file url for enterprise * fix file path by using filePath instead of class path * add UTs * update comment (#19) * update comment * fix parsing * make use of another github token * release 0.0.4
tarek360
added a commit
that referenced
this pull request
Nov 21, 2018
* introduce JacocoCoverageRule (#6) * introduce JacocoCoverageRule * add JacocoCoverageRuleTest * support all nested objects * improve test coverage * add more tests * make issue levels take text (#8) * config bintray * convert the Rule to abstract class (#7) * convert the Rule to abstract class * fix push.gradle * auto release (#9) * auto release * add release task to circle ci * add ci and pullRequest to Rule (#10) * add ci and pullRequest to Rule * fix test * exclude some authors from protected files rule (#11) * jacoco total coverage (#12) * introduce Github-enterprise (#15) * Unify dependencies versions by applying buildSrc (#14) * Making unify dependencies versions feature by applying buildSrc mechanism and Gradle DSL then change all the build.gradle.kts files of all the modules we have to be use the new kotlin class that I made. Since four classes are made : 1. Dependencies : that contains all the dependencies we will use. 2. MainApp : that contains the common things of the whole app. 3. MainClass : that contains the main classes of each module. 4. Projects : that contains the name of projects/modules we have tell now. 5. Versions : that contains the versions that we will use in Dependencies class. * Modify Naming of buildSrc files - Projects file renamed to Modules to be more meaningful. - MainApp file renamed to Project to be more specific. * fix file url for enterprise (#18) * fix file url for enterprise * fix file path by using filePath instead of class path * add UTs * update comment (#19) * update comment * fix parsing * make use of another github token * release 0.0.4 * support teamcity (#21)
tarek360
added a commit
that referenced
this pull request
Aug 4, 2019
* introduce JacocoCoverageRule (#6) * introduce JacocoCoverageRule * add JacocoCoverageRuleTest * support all nested objects * improve test coverage * add more tests * make issue levels take text (#8) * config bintray * convert the Rule to abstract class (#7) * convert the Rule to abstract class * fix push.gradle * auto release (#9) * auto release * add release task to circle ci * add ci and pullRequest to Rule (#10) * add ci and pullRequest to Rule * fix test * exclude some authors from protected files rule (#11) * jacoco total coverage (#12) * introduce Github-enterprise (#15) * Unify dependencies versions by applying buildSrc (#14) * Making unify dependencies versions feature by applying buildSrc mechanism and Gradle DSL then change all the build.gradle.kts files of all the modules we have to be use the new kotlin class that I made. Since four classes are made : 1. Dependencies : that contains all the dependencies we will use. 2. MainApp : that contains the common things of the whole app. 3. MainClass : that contains the main classes of each module. 4. Projects : that contains the name of projects/modules we have tell now. 5. Versions : that contains the versions that we will use in Dependencies class. * Modify Naming of buildSrc files - Projects file renamed to Modules to be more meaningful. - MainApp file renamed to Project to be more specific. * fix file url for enterprise (#18) * fix file url for enterprise * fix file path by using filePath instead of class path * add UTs * update comment (#19) * update comment * fix parsing * make use of another github token * release 0.0.4 * support teamcity (#21) * Create README.md * pull request expose more info (#23) * add custom rule post link * Update README.md * introduce debuggable flag (#24) * update version to 0.0.4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix file url for github enterprise..