Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default exclude dial #6607

Merged

Conversation

hansieodendaal
Copy link
Contributor

Description

Added default exclude dial

Motivation and Context

Too many dials to test addresses

How Has This Been Tested?

To be evaluated in testnet

What process can a PR reviewer use to test or verify this change?

Code review

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@hansieodendaal hansieodendaal requested a review from a team as a code owner October 7, 2024 13:07
Copy link

github-actions bot commented Oct 7, 2024

Test Results (CI)

    3 files    129 suites   35m 35s ⏱️
1 327 tests 1 327 ✅ 0 💤 0 ❌
3 979 runs  3 979 ✅ 0 💤 0 ❌

Results for commit 6bde4d5.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

Test Results (Integration tests)

 2 files  11 suites   23m 30s ⏱️
36 tests 35 ✅ 0 💤 1 ❌
37 runs  36 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 6bde4d5.

Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

Was able to create a wallet again, and connected to seed nodes.

@SWvheerden SWvheerden merged commit 332068f into tari-project:development Oct 7, 2024
16 of 17 checks passed
@hansieodendaal hansieodendaal deleted the ho_excluded_dial_addresses branch October 8, 2024 10:18
sdbondi added a commit to sdbondi/tari that referenced this pull request Oct 10, 2024
* development:
  chore(ci): remove ledger nanos and update ledger key gif resources (tari-project#6617)
  feat: improve mempool error msg when mempool out of sync (tari-project#6618)
  feat: exit logic for pre-mine spend (tari-project#6615)
  chore: new release esme v1.6.0-pre.0 (tari-project#6614)
  feat: enable identity grpc method by default (tari-project#6613)
  feat: pre-mine introduce temp ban and add counters (tari-project#6612)
  chore: changes mainnet default network (tari-project#6610)
  chore(ci): add riscv64 builds and misc script fixes (tari-project#6611)
  feat!: esme test pre-mine with immediate spend (tari-project#6609)
  feat!: add context to ffi callbacks (tari-project#6608)
  feat: add default exclude dial (tari-project#6607)
  feat!: add input mr into genesis block (tari-project#6601)
  feat: update pre_mine specification (tari-project#6606)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants