Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pre-mine introduce temp ban and add counters #6612

Merged

Conversation

hansieodendaal
Copy link
Contributor

Description

  • Added pre-mine counters so the progress could be displayed.
  • Temporarily ban all base node peers when doing pre-mine-spend-encumber-aggregate-utxo and pre-mine-spend-aggregate-transaction to prevent the wallet from broadcasting the incomplete transactions.

Motivation and Context

Improved UX

How Has This Been Tested?

System-level testing

What process can a PR reviewer use to test or verify this change?

Code review

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Added pre-mine counters so the progress could be displayed.
@hansieodendaal hansieodendaal requested a review from a team as a code owner October 8, 2024 10:22
@SWvheerden SWvheerden changed the title feat: pre-mine introduce temp ban and add counters feat: pre-mine introduce temp ban and add counters Oct 8, 2024
@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

Test Results (CI)

    3 files    129 suites   33m 43s ⏱️
1 326 tests 1 326 ✅ 0 💤 0 ❌
3 976 runs  3 976 ✅ 0 💤 0 ❌

Results for commit a16f96d.

Copy link

github-actions bot commented Oct 8, 2024

Test Results (Integration tests)

36 tests   36 ✅  14m 28s ⏱️
11 suites   0 💤
 2 files     0 ❌

Results for commit a16f96d.

SWvheerden
SWvheerden previously approved these changes Oct 8, 2024
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a nit about the text

@SWvheerden SWvheerden merged commit d97d00d into tari-project:development Oct 8, 2024
15 checks passed
@hansieodendaal hansieodendaal deleted the ho_add_pre_mine_counters branch October 8, 2024 14:19
sdbondi added a commit to sdbondi/tari that referenced this pull request Oct 10, 2024
* development:
  chore(ci): remove ledger nanos and update ledger key gif resources (tari-project#6617)
  feat: improve mempool error msg when mempool out of sync (tari-project#6618)
  feat: exit logic for pre-mine spend (tari-project#6615)
  chore: new release esme v1.6.0-pre.0 (tari-project#6614)
  feat: enable identity grpc method by default (tari-project#6613)
  feat: pre-mine introduce temp ban and add counters (tari-project#6612)
  chore: changes mainnet default network (tari-project#6610)
  chore(ci): add riscv64 builds and misc script fixes (tari-project#6611)
  feat!: esme test pre-mine with immediate spend (tari-project#6609)
  feat!: add context to ffi callbacks (tari-project#6608)
  feat: add default exclude dial (tari-project#6607)
  feat!: add input mr into genesis block (tari-project#6601)
  feat: update pre_mine specification (tari-project#6606)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants