Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated futures-rs, tokio, tower and rust #836

Closed
wants to merge 1 commit into from

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Oct 11, 2019

Description

  • rust nightly-2019-10-04 (Requires new docker image build)
  • futures alpha.19
  • tokio alpha.6
  • tower alpha2

Came across this panic in the rust compiler in #837 :
rust-lang/rust#64385

Motivation and Context

Compilation panics on currently used rust version. Issue: rust-lang/rust#64385
futures-rs and tokio upgrades because tower 0.3.0-alpha.2 uses futures=0.3.0-alpha.19

How Has This Been Tested?

Existing tests pass

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch
  • I ran cargo-fmt --all before pushing
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@sdbondi sdbondi self-assigned this Oct 11, 2019
- rust nightly-2019-10-04 (Requires new docker image build)
- futures alpha.19
- tokio alpha.6
- tower alpha2

Came across this panic in the rust compiler in a PR to follow:
rust-lang/rust#64385
@CjS77
Copy link
Collaborator

CjS77 commented Oct 14, 2019

Covered in #837

@CjS77 CjS77 closed this Oct 14, 2019
@CjS77 CjS77 deleted the sb-upgrade-futures-rust branch October 24, 2019 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants