Filter Store and forward messages if feature is not enabled #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rust nightly-2019-10-04 (Requires new docker image build) - futures alpha.19 - tokio alpha.6 - tower alpha2 Came across this panic in the rust compiler in a PR to follow: rust-lang/rust#64385
sdbondi
force-pushed
the
sb-filter-saf-messages
branch
from
8538621 to
10514c4
Compare
- Store and forward messages are discarded when they are not supported by the node - To implement this, tower-filter was used. However, it is not released yet for futures 0.3 so I've included it directly in this PR
sdbondi
force-pushed
the
sb-filter-saf-messages
branch
from
10514c4 to
f38b937
Compare
11 tasks
|
This requires a new docker image for rust nightly-2019-10-04 |
sdbondi
force-pushed
the
sb-filter-saf-messages
branch
from
07f7ce8 to
9c0b883
Compare
CjS77
added a commit
that referenced
this pull request
Oct 14, 2019
Merge pull request #837 Updated futures-rs, tokio, tower and rust Filter Store and forward messages if feature is not enabled updated croaring to =0.3.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base PR: #836
Description
by the node
yet for futures 0.3 so I've included it directly in this PR
Motivation and Context
Closes #831
How Has This Been Tested?
Unit test for working filter
Types of changes
Checklist:
developmentbranchcargo-fmt --allbefore pushing