Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong distrib name with dune-release 1.5.0 #381

Closed
voodoos opened this issue Jul 26, 2021 · 5 comments · Fixed by #383
Closed

Wrong distrib name with dune-release 1.5.0 #381

voodoos opened this issue Jul 26, 2021 · 5 comments · Fixed by #383

Comments

@voodoos
Copy link
Member

voodoos commented Jul 26, 2021

When releasing Merlin dune-released refused to sue the tag name as a version for the archive file and the release name. Instead it used the name merlin leading to the confusing archive name merlin-merlin.tbz.

$ dune-release tag v4.3-411
$ dune-release distrib
[-] Building source archive
[+] Wrote archive _build/merlin-merlin.tbz

With dune-release 1.4.0 I get the expected behavior:

$ dune-release tag v4.3-411
$ dune-release distrib
[-] Building source archive
[+] Wrote archive _build/merlin-v4.3-411.tbz

I wonder if that could come from undesirable tag detection since our changelog starts with:

merlin 4.3
----------
changes....

To reproduce, you can do a dry run on current merlin master.
@NathanReb
Copy link
Contributor

This is from #271, we kind of saw it coming at the time, not sure why we decided not to do the proposed reverse tag parsing thing.

I'll work on a fix!

Out of curiosity is there any reason why you don't want to follow dune-release expected changelog scheme?

@voodoos
Copy link
Member Author

voodoos commented Jul 28, 2021

Out of curiosity is there any reason why you don't want to follow dune-release expected changelog scheme?

Just plain old conservatism... and to provide nice edge-cases for dune-release testing! cough

@gpetiot
Copy link
Contributor

gpetiot commented Jul 28, 2021

Maybe we should add a more verbose output (à la autoconf/configure) to dune-release check so we can output the tag, the version, etc. to avoid bad surprises like these.

@Leonidas-from-XIV Leonidas-from-XIV mentioned this issue Sep 6, 2021
Merged
@Leonidas-from-XIV
Copy link
Member

@voodoos Could you please try out the branch in #383? We changed the logic of #271 to simplify the escaping rules and to read the version back from the tag when using distrib so it should.. just work again.

@voodoos
Copy link
Member Author

voodoos commented Sep 16, 2021

@voodoos Could you please try out the branch in #383? We changed the logic of #271 to simplify the escaping rules and to read the version back from the tag when using distrib so it should.. just work again.

I have nothing to release right now... but we should have a Merlin release in one or two weeks...

Leonidas-from-XIV added a commit to Leonidas-from-XIV/opam-repository that referenced this issue Oct 8, 2021
@Leonidas-from-XIV
[new release] dune-release (1.5.1)
7d92c16 
CHANGES:

### Added

- Added support for creating releases from unannotated Git tags. `dune-release`
  supported unannotated tags in a few places already, now it supports using
  them for creating a release. (tarides/dune-release#383, @Leonidas-from-XIV)

### Fixed

- Change the `---V` command option to be `-V` (tarides/dune-release#388, @Leonidas-from-XIV)
- Infer release versions are inferred from VCS tags. This change allows using
  `dune-release` on projects that do not use the changelog or have it in a
  different format.  (tarides/dune-release#381, tarides/dune-release#383 @Leonidas-from-XIV)
- Fix a bug where `dune-release` couldn't retrieve a release on GitHub if the
  tag and project version don't match (e.g. `v1.0` vs `1.0`). `dune-release`
  would in such case believe the release doesn't exist, attempt to create it
  and subsequently fail. (tarides/dune-release#387, tarides/dune-release#395, @Leonidas-from-XIV)
@Leonidas-from-XIV Leonidas-from-XIV mentioned this issue Oct 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Infer version from tag Leonidas-from-XIV/dune-release
4 participants
@Leonidas-from-XIV @gpetiot @voodoos @NathanReb