Fix ---V to be -V
#388
Merged
Fix ---V to be -V
#388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cmdliner accepts everything that is longer than one character as a long option, hence it made `-V` into `---V` long option.
NathanReb
approved these changes
Sep 9, 2021
|
The |
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Oct 8, 2021
CHANGES: ### Added - Added support for creating releases from unannotated Git tags. `dune-release` supported unannotated tags in a few places already, now it supports using them for creating a release. (tarides/dune-release#383, @Leonidas-from-XIV) ### Fixed - Change the `---V` command option to be `-V` (tarides/dune-release#388, @Leonidas-from-XIV) - Infer release versions are inferred from VCS tags. This change allows using `dune-release` on projects that do not use the changelog or have it in a different format. (tarides/dune-release#381, tarides/dune-release#383 @Leonidas-from-XIV) - Fix a bug where `dune-release` couldn't retrieve a release on GitHub if the tag and project version don't match (e.g. `v1.0` vs `1.0`). `dune-release` would in such case believe the release doesn't exist, attempt to create it and subsequently fail. (tarides/dune-release#387, tarides/dune-release#395, @Leonidas-from-XIV)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cmdliner accepts everything that is longer than one character as a long option, hence it made
-Vinto---Vlong option.This has been broken since
-Vwas added in 809f539, so maybe nobody uses it and it might sense to just remove that option?