Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be strict with modifiers on matching < & > #105

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

miraclx
Copy link
Contributor

@miraclx miraclx commented Feb 26, 2021

Ignore modifier-bound keyevents. e.g alt+< shouldn't have the same action as <.

In ref to #93

@tarkah tarkah merged commit f8427be into tarkah:feat/kagi Feb 26, 2021
@miraclx miraclx deleted the strict-chart-scroll branch February 26, 2021 17:06
tarkah added a commit that referenced this pull request Feb 26, 2021
* add kagi chart

still need to add ability to define custom reversal amounts from config
file and in the GUI

* remember show volumes state when disabling for kagi

* add chart_type option

* add chart configuration widget

* add high low for kagi

* add kagi options to config

* allow reversals per time frame

* fix single / none match

* fix clippy

* update CHANGELOG

* add support for < & >

this doesn't work currently, but no reason to redo it when
#95 needs to be merged first
and we can rebase the proper change to that

* disable 'c' while config pane open

* properly only change selected time frame

* support backtab in chart config pane (#103)

* be strict with modifiers on matching < & > (#105)

* intuitive keybindings (#104)

* use more intuitive keybindings

up/down or tab/backtab to switch widgets

left/right to choose options

* increase info/error message box to contain all entries

* disable q:quit with kagi config pane open (#102)

* disable q:quit with kagi config pane open

* reassign q binding to close kagi config pane

* add help entry for chart config pane (#109)

* allow chart scroll with side pane open (#106)

* allow scrolling chart while on chart config pane

* allow scrolling chart while on options pane

Co-authored-by: Miraculous Owonubi <omiraculous@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants