allow chart scroll with side pane open #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can rebase this, #105 is merged |
miraclx
force-pushed
the
chart-scroll-with-config
branch
from
cd032b0
to
e5bfd06
Compare
|
Any reason this is still a draft? |
|
For feat/kagi, not really. But I'm thinking the PR should support chart scrolling for any side pane. Including the options pane. That can be another PR on master though. What do you think? |
|
I agree, lets just roll that out in here so it's good to go when I release #93 |
tarkah
added a commit
that referenced
this pull request
Feb 26, 2021
* add kagi chart still need to add ability to define custom reversal amounts from config file and in the GUI * remember show volumes state when disabling for kagi * add chart_type option * add chart configuration widget * add high low for kagi * add kagi options to config * allow reversals per time frame * fix single / none match * fix clippy * update CHANGELOG * add support for < & > this doesn't work currently, but no reason to redo it when #95 needs to be merged first and we can rebase the proper change to that * disable 'c' while config pane open * properly only change selected time frame * support backtab in chart config pane (#103) * be strict with modifiers on matching < & > (#105) * intuitive keybindings (#104) * use more intuitive keybindings up/down or tab/backtab to switch widgets left/right to choose options * increase info/error message box to contain all entries * disable q:quit with kagi config pane open (#102) * disable q:quit with kagi config pane open * reassign q binding to close kagi config pane * add help entry for chart config pane (#109) * allow chart scroll with side pane open (#106) * allow scrolling chart while on chart config pane * allow scrolling chart while on options pane Co-authored-by: Miraculous Owonubi <omiraculous@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow chart scrolling when a side pane (options or config) is open
This merges #105, and is in ref to #93