fix #65: avoid worker crash in case connection is broken #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s3rius
requested changes
Jul 1, 2024
Sure, I was going to open an issue. The issue is that if the connection is disrupted (due to a Redis restart or temporary connectivity issues), the Taskiq worker crashes, interrupting all ongoing handlers. For example, any long-running tasks will be interrupted and will not complete their work. |
khizunov
force-pushed
the
anton/try_except_listen
branch
from
499538a to
ece9df8
Compare
khizunov
changed the title
|
@s3rius did you have a chance to look at it? |
|
Please rebase onto main branch and we will merge it. |
s3rius
approved these changes
Sep 26, 2024
khizunov
force-pushed
the
anton/try_except_listen
branch
from
1034306 to
b5e9328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that if the connection is disrupted (due to a Redis restart or temporary connectivity issues), the Taskiq worker crashes, interrupting all ongoing handlers. For example, any long-running tasks will be interrupted and will not complete their work.