Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #65: avoid worker crash in case connection is broken #64

Merged
merged 1 commit into from
Sep 28, 2024
Merged

fix #65: avoid worker crash in case connection is broken #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions taskiq_redis/redis_broker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,12 @@ async def listen(self) -> AsyncGenerator[bytes, None]:
:yields: broker messages.
"""
redis_brpop_data_position = 1
async with Redis(connection_pool=self.connection_pool) as redis_conn:
while True:
yield (await redis_conn.brpop(self.queue_name))[
redis_brpop_data_position
]
while True:
try:
async with Redis(connection_pool=self.connection_pool) as redis_conn:
s3rius marked this conversation as resolved.
Show resolved Hide resolved
yield (await redis_conn.brpop(self.queue_name))[
redis_brpop_data_position
]
except ConnectionError as exc:
logger.warning("Redis connection error: %s", exc)
continue
Loading