Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App breakage should be a factor in removal. #1203

Closed
addyosmani opened this issue Mar 14, 2015 · 9 comments · Fixed by #1294
Closed

App breakage should be a factor in removal. #1203

addyosmani opened this issue Mar 14, 2015 · 9 comments · Fixed by #1294
Assignees

Comments

@addyosmani
Copy link
Member

Maybe we should include some verbiage in our acceptance rules to cover long term breakage of an implementation. This is a particularly poor experience for users and doesnt look good for authors either.

Like, if an app has been broken for N releases without update it gets removed until fixed.

This has the potential to encourage more authors to actively check in.

@arthurvr
Copy link
Member

Yes, I can only agree with that. 👍

@sindresorhus
Copy link
Member

👍

1 similar comment
@passy
Copy link
Member

passy commented Mar 14, 2015

👍

@arthurvr
Copy link
Member

@tastejs/todomvc I think we all agree on this, so do we want to document this somewhere, or can we close the issue?

@samccone
Copy link
Member

I think we can close this since we all agree, just good to have documented in the issue right?¿

@addyosmani
Copy link
Member Author

Agreed. We should prob document somewhere though. Wiki?
On 24 Mar 2015 3:02 am, "Sam Saccone" notifications@github.com wrote:

I think we can close this since we all agree, just good to have documented
in the issue right?¿


Reply to this email directly or view it on GitHub
#1203 (comment).

@arthurvr
Copy link
Member

Seems fine. Will take care of that this weekend.

@arthurvr arthurvr self-assigned this Mar 24, 2015
@arthurvr
Copy link
Member

Anyone an idea where we should have this documented? Maybe we should have a whole paragraph in the contributing.md about being around to help us maintain your app after submitting it?

@arthurvr
Copy link
Member

I would honestly love it if we could say something like

Please think about the fact that contributing a new app means more than just
a one-off pull request submitting the app. When the app gets included on the site,
you will need to help use maintaining the app and help us to solve issues with the
implementation. If the app breaks for a decent amount of time, we will (temporary)
remove it from the site, until somebody opens a PR to fix the raised issues.

but guess it's a little too much?

arthurvr added a commit to arthurvr/todomvc that referenced this issue May 13, 2015
arthurvr added a commit to arthurvr/todomvc that referenced this issue May 13, 2015
arthurvr added a commit to arthurvr/todomvc that referenced this issue May 13, 2015
arthurvr added a commit to arthurvr/todomvc that referenced this issue May 13, 2015
arthurvr added a commit to arthurvr/todomvc that referenced this issue May 13, 2015
mhoyer pushed a commit to mhoyer/todomvc that referenced this issue Dec 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants