Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Montage app totally broken! #1222

Closed
arthurvr opened this issue Mar 20, 2015 · 9 comments
Closed

Montage app totally broken! #1222

arthurvr opened this issue Mar 20, 2015 · 9 comments
Milestone
1.4

Comments

@arthurvr
Copy link
Member

/cc @mczepiel
@mczepiel
Copy link
Contributor

Thanks for the heads up, I've brought this to the attention of @marchant /cc @rayshan as I'm a little booked right now myself.

@samccone
Copy link
Member

it is worth nothing that it has been broken for some time, it might be best to remove from the site and reintroduce when someone fixes it, as compared to having a broken version on the site.

@arthurvr
Copy link
Member Author

Definitely. That's what's being discussed in #1203. Would not do it directly as the issue is just opened, but if it isn't fixed quick that seems reasonable to me.

@marchant
Copy link

Working on it, expect a PR in the next few days

@samccone
Copy link
Member

👍 thanks @marchant

@arthurvr
Copy link
Member Author

Thanks @marchant!

@arthurvr
Copy link
Member Author

Friendly ping

@marchant
Copy link

I did submit a PR yesterday, need more feedback to adress some concerns that were raised

On Mar 30, 2015, at 06:19, Arthur Verschaeve notifications@github.com wrote:

Friendly ping

—
Reply to this email directly or view it on GitHub.

@arthurvr
Copy link
Member Author

aggrr. Didn't see that one. Shall take a look :)

@arthurvr arthurvr mentioned this issue Mar 30, 2015
Closed
@arthurvr arthurvr mentioned this issue Jul 2, 2015
Closed
5 tasks
@passy passy added this to the 1.4 milestone Jul 2, 2015
mhoyer pushed a commit to mhoyer/todomvc that referenced this issue Dec 5, 2015
@arthurvr @mhoyer
(Temporarily) drop montage app
59f71fe 
The app is getting outdated and is these days even totally broken sowe
decided to remove it, till someone volunteers to maintain it and PRs it
back with all remaining issues fixed.

There was an open PR with some updates but it went inactive:
tastejs#1241

Close tastejs#1241
Fix tastejs#1222
Ref tastejs#1234
Ref tastejs#1110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4
Development

No branches or pull requests
5 participants
@mczepiel @passy @marchant @samccone @arthurvr