-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New app UI & switch to npm for dependencies #1110
Comments
@tastejs/todomvc |
Thanks so much for this, Sindre. I love the new layout and you know that I was a bit sceptical on the first iteration, but this one is perfect. <3 Have you registered the new repo with |
I just opened a PR for the jQuery example. I'm willing to open one for some other examples too. |
@kamilogorek Nice! @arthurvr Weeeee 💃 |
I'll take on updating the Polymer app (unless it's been started already). |
Somebody may tick the vanilla js example too. My PR just got merged. |
Done! 👊 |
Just got out two extra PRs. One for the Aria templates example, the other one for Batman. Probably some others coming tomorrow. |
@arthurvr Woot! You're on fire: |
* Included `todomvc-app-css`, this includes the new UI. * Replaced bower by NPM. * Include all files that aren't needed in the repo in the gitignore Ref tastejsgh-1110
* Included `todomvc-app-css`, this includes the new UI. * Replaced bower by NPM. * Include all files that aren't needed in the repo in the gitignore Ref tastejs#1110
The app is getting outdated and is these days even totally broken sowe decided to remove it, till someone volunteers to maintain it and PRs it back with all remaining issues fixed. There was an open PR with some updates but it went inactive: tastejs#1241 Close tastejs#1241 Fix tastejs#1222 Ref tastejs#1234 Ref tastejs#1110
I think now this issue is resolved. |
I finally managed to finish the new app UI.
Now we just need to switch the apps over. No structural changes should be needed.
I took the liberty to change from bower to npm as that's the future and it makes it easier for us to deal with dependencies. We should also .gitignore any unwanted file so to make it easier to upgrade dependencies in the future.
todomvc-common
no longer contains the app CSS, only the learning-bar. The app CSS is in thetodomvc-app-css
module.I've converted the backbone app as an example. (live demo).
Help from anyone more than welcome.
Apps needing updating
The text was updated successfully, but these errors were encountered: