Update ancient emberjs version and use ember-cli #1582

cibernox · 2016-01-12T21:56:26Z

READY TO MERGE

The current version uses Ember 1.4, which is pretty ancient and the idioms are completely outdated.

This version uses Ember 2.3 and uses ember-cli as build tool.

The structure pretty different to the suggested one because of ember-cli. Ember-cli is the build took used by nearly 100% of ember projects and not using ember-cli in 2016 would be totally nuts.
I don't know if how the build system that deploys the demos works, I'll dig into it.

People in the community will review it.

samccone · 2016-01-12T22:02:17Z

Welcome @cibernox! I am excited to have you looking at this,

Let me know when you would like a review 👀 ...

xref

#1333
#1069
#1134
#1110
#1360
#1362

locks · 2016-01-12T22:24:53Z

examples/ember-cli/app/controllers/active.js

+import Ember from 'ember';
+
+export default Ember.Controller.extend({
+  todos: Ember.computed.filterBy('model', 'completed', false),


left-over comma

samccone · 2016-01-12T22:33:35Z

@cibernox

Some things to check

Vendor all the dependencies for the final project in the repo
Tests should be green (they are really reliable)
Add any code that should not be linted to our root jscs file in the repo

cibernox · 2016-01-12T22:51:39Z

@samccone Just one question. Is 4 spaces indentation a hard requirement?

samccone · 2016-01-12T22:56:19Z

it is unless the language does not support it.

I do not like it either, but consistency wins the argument here

cibernox · 2016-01-19T20:06:21Z

@samccone I'm back with this, after update it to ember 2.3 final, but I'm seeing some failures in travis that don't seem related with the PR itself.

Can you check the travis log to see if I'm missing something?

addyosmani · 2016-04-04T12:49:06Z

I'm currently seeing CI failures here:


/home/travis/build/tastejs/todomvc/tests/node_modules/selenium-webdriver/lib/goog/async/nexttick.js:41
  goog.global.setTimeout(function() { throw exception; }, 0);
                                      ^
NoSuchElementError: no such element: Unable to locate element: {"method":"css selector","selector":".todo-list li"}
  (Session info: chrome=49.0.2579.0)
  (Driver info: chromedriver=2.20.353124 (035346203162d32c80f1dce587c8154a1efa0c3b),platform=Linux 3.13.0-40-generic x86_64)
    at new bot.Error (/home/travis/build/tastejs/todomvc/tests/node_modules/selenium-webdriver/lib/atoms/error.js:108:18)
    at Object.bot.response.checkResponse (/home/travis/build/tastejs/todomvc/tests/node_modules/selenium-webdriver/lib/atoms/response.js:109:9)
    at /home/travis/build/tastejs/todomvc/tests/node_modules/selenium-webdriver/lib/webdriver/webdriver.js:379:20
    at promise.Promise.goog.defineClass.invokeCallback_ (/home/travis/build/tastejs/todomvc/tests/node_modules/selenium-webdriver/lib/goog/../webdriver/promise.js:1337:14)
    at promise.ControlFlow.goog.defineClass.goog.defineClass.abort_.error.executeNext_.execute_ (/home/travis/build/tastejs/todomvc/tests/node_modules/selenium-webdriver/lib/goog/../webdriver/promise.js:2776:14)
    at promise.ControlFlow.goog.defineClass.goog.defineClass.abort_.error.executeNext_ (/home/travis/build/tastejs/todomvc/tests/node_modules/selenium-webdriver/lib/goog/../webdriver/promise.js:2758:21)
    at goog.async.run.processWorkQueue (/home/travis/build/tastejs/todomvc/tests/node_modules/selenium-webdriver/lib/goog/async/run.js:124:15)
    at process._tickCallback (node.js:401:9)
From: Task: WebElement.isDisplayed()
    at webdriver.WebDriver.schedule (/home/travis/build/tastejs/todomvc/tests/node_modules/selenium-

As far as I can tell, these aren't strictly related to the PR itself. Will keep digging. cc @samccone @passy in case they have any ideas.

addyosmani · 2016-04-04T12:51:21Z

(Side: if we have time, we might want to bump to ember-cli 2.4.3 as part of this PR)

Turbo87 · 2016-04-04T13:05:16Z

examples/ember-cli/todomvc/app/controllers/application.js

+export default Ember.Controller.extend({
+	repo: Ember.inject.service(),
+	remaining: Ember.computed.filterBy('model', 'completed', false),
+	completed: Ember.computed.filterBy('model', 'completed', true),


these two seem to be unused, or did I miss something?

samccone · 2016-04-04T14:55:01Z

re @addyosmani a rebase off of master should resolve this test failure (it is due to selenium making a breaking change)

cibernox · 2016-04-04T15:51:26Z

@samccone I'll rebase this and go to sleep.

cibernox · 2016-05-20T11:10:26Z

@samccone I'm resuscitating this but I still have no idea how to make tests pass. I think that whatever the test runner is doing, it doesn't like my file structure.

Who can give me a hand with this?

cibernox · 2016-05-20T21:36:03Z

Ok, I figure this out. I'll let someone else review the code but should be good to go in a couple days top.

locks · 2016-05-20T21:42:59Z

examples/ember-cli/todomvc/app/components/todo-item.js

+		startEditing() {
+			this.get('onStartEdit')();
+			this.set('editing', true);
+			Ember.run.scheduleOnce('afterRender', this, 'focusInput');


this is a bit hackish :\

Afaik there is no other way.

would moving it to didRender wouldn't work?

didRender will be called whenever this component is rendered or rerendered, while this is a one-time only action. This has to happen specifically after this action and never again.

autofocus attr doesn't work here?

cibernox · 2016-05-21T17:55:33Z

This PR is done. Feel free to merge.

Ember 2.6 and Ember-cli 2.6 will be out next week and I'll update this then. I intend to keep this up to date from now own and avoid it to fall far behind again.

samccone · 2016-05-23T17:57:17Z

oh awesomeeeee 👯 we just need someone who knows ember to review this... any ideas?

cibernox · 2016-05-23T19:39:16Z

@samccone I think that Ember 2.6 is going to be released tonight, so I'll wait one more day before merging. I'll ask someone in the core team to sanction this PR.

locks · 2016-05-23T19:45:12Z

examples/ember-cli/todomvc/app/services/repo.js

+export default Ember.Service.extend({
+	lastId: 0,
+	data: null,
+	findAll() {


can you add a blank line above, just stylistic purposes?

samccone · 2016-06-10T01:34:37Z

💥 time to land this one :)

Thanks a million @cibernox

cibernox · 2016-06-10T12:54:32Z

@samccone Do I need to create another PR to point the Ember.js version in the main page to this version instead of the 1.10 one?

samccone · 2016-06-10T15:45:02Z

@cibernox no :)

Looks like something broke in our autodeploy script
#1635

I am going to investigate --- when that is fixed then things will autoflow from here. I plan on taking a look after my workday ends today.

cibernox · 2016-06-10T15:49:57Z

This example didn't replace the old one. It was created with a different name (ember-cli), so I don't think it can be automated.

samccone · 2016-06-10T16:05:18Z

oh right of course :P Yeah we can switch up the link quite easily

cibernox · 2016-06-10T16:08:03Z

Maybe it could replace it tho, because saying Ember today effectively means saying ember + ember-cli. It is the officially sanctioned path.

samccone · 2016-06-10T16:35:38Z

I am 100000% fine with removing it since the old one is very outdated. git mv FTW

samccone added the emberjs label Jan 12, 2016

cibernox force-pushed the add-ember-cli-project branch from ddd2e30 to 707c437 Compare January 12, 2016 22:15

locks reviewed Jan 12, 2016
View reviewed changes

cibernox force-pushed the add-ember-cli-project branch 3 times, most recently from 82b2e0e to 1221e18 Compare January 12, 2016 22:49

cibernox force-pushed the add-ember-cli-project branch 6 times, most recently from a559557 to 01b855b Compare January 13, 2016 09:38

Turbo87 reviewed Apr 4, 2016
View reviewed changes

cibernox force-pushed the add-ember-cli-project branch 4 times, most recently from 3b72fa7 to d904190 Compare April 4, 2016 17:32

cibernox force-pushed the add-ember-cli-project branch 3 times, most recently from 324edde to d797874 Compare May 20, 2016 11:08

Ember-cli version

c5a0e53

cibernox force-pushed the add-ember-cli-project branch from d797874 to c5a0e53 Compare May 20, 2016 21:32

locks reviewed May 20, 2016
View reviewed changes

cibernox force-pushed the add-ember-cli-project branch 2 times, most recently from 24e4a1f to 2faec97 Compare May 21, 2016 17:52

Applied feedback

b72d5e5

cibernox force-pushed the add-ember-cli-project branch from 2faec97 to b72d5e5 Compare May 21, 2016 17:54

locks reviewed May 23, 2016
View reviewed changes

Update to Ember 2.6

5244ce4

samccone merged commit 8019b40 into tastejs:master Jun 10, 2016

cibernox deleted the add-ember-cli-project branch June 10, 2016 12:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update ancient emberjs version and use ember-cli #1582

Update ancient emberjs version and use ember-cli #1582

cibernox commented Jan 12, 2016 •

edited

Loading

samccone commented Jan 12, 2016

locks Jan 12, 2016

samccone commented Jan 12, 2016

cibernox commented Jan 12, 2016

samccone commented Jan 12, 2016

cibernox commented Jan 19, 2016

addyosmani commented Apr 4, 2016

addyosmani commented Apr 4, 2016

Turbo87 Apr 4, 2016

samccone commented Apr 4, 2016

cibernox commented Apr 4, 2016

cibernox commented May 20, 2016

cibernox commented May 20, 2016

locks May 20, 2016

cibernox May 21, 2016

locks May 21, 2016

cibernox May 21, 2016

devinrhode2 Jun 10, 2016

cibernox commented May 21, 2016

samccone commented May 23, 2016

cibernox commented May 23, 2016

locks May 23, 2016

samccone commented Jun 10, 2016

cibernox commented Jun 10, 2016

samccone commented Jun 10, 2016 •

edited

Loading

cibernox commented Jun 10, 2016

samccone commented Jun 10, 2016

cibernox commented Jun 10, 2016

samccone commented Jun 10, 2016

Update ancient emberjs version and use ember-cli #1582

Update ancient emberjs version and use ember-cli #1582

Conversation

cibernox commented Jan 12, 2016 • edited Loading

samccone commented Jan 12, 2016

Choose a reason for hiding this comment

samccone commented Jan 12, 2016

cibernox commented Jan 12, 2016

samccone commented Jan 12, 2016

cibernox commented Jan 19, 2016

addyosmani commented Apr 4, 2016

addyosmani commented Apr 4, 2016

Choose a reason for hiding this comment

samccone commented Apr 4, 2016

cibernox commented Apr 4, 2016

cibernox commented May 20, 2016

cibernox commented May 20, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cibernox commented May 21, 2016

samccone commented May 23, 2016

cibernox commented May 23, 2016

Choose a reason for hiding this comment

samccone commented Jun 10, 2016

cibernox commented Jun 10, 2016

samccone commented Jun 10, 2016 • edited Loading

cibernox commented Jun 10, 2016

samccone commented Jun 10, 2016

cibernox commented Jun 10, 2016

samccone commented Jun 10, 2016

cibernox commented Jan 12, 2016 •

edited

Loading

samccone commented Jun 10, 2016 •

edited

Loading