Migrates Ember app to new UI 🚚

[naz]

refs #1110

• upgrade to new UI
• didn't migrate to npm as they are not hosted there in ember's case
• fixed a little bug on 'Clear completed' button as it wa missplaced with new styles

[naz]

btw, was running browser tests and it seems like these are failing:

Clear completed button
  1) should display the number of completed items
  2) should remove completed items when clicked
  3) should be hidden when there are no items that are completed

I guess, they will be updated whenever all the apps are migrated to new UI.

[sindresorhus]

didn't migrate to npm as they are not hosted there in ember's case

ember-data and ember-localstorage-adapter are on npm. As for ember you can still reference it using the git repo.

{
  "ember": "emberjs/ember.js#v1.10.0-beta.4"
}

Would you mind opening a ticket on Ember about keeping the npm ember package up to date?

[arthurvr]

Would you mind opening a ticket on Ember about keeping the npm ember package up to date?

@sindresorhus There already is: emberjs/ember.js#9354.

[naz]

tried updating to npm, but it seems like having an ember repo wont help much as they don't have actual ember.js file in their source it is generated and then pushed to different distribution channels. should we stay with bower or have regular ember.js file commited ?

[sindresorhus]

@gargol Actually, they have this for the dist: https://github.com/components/ember/blob/master/package.json

[naz]

sorry guys, having hard time figuring this out. tried doing it with this config:

{
  "private": true,
  "dependencies": {
    "todomvc-app-css": "^1.0.0",
    "todomvc-common": "^1.0.1",
    "jquery": "^2.1.0",
    "handlebars": "^2.0.0",
    "ember": "components/ember#1.10.0-beta.3",
    "ember-data": "components/ember-data#1.0.0-beta.14.1",
    "ember-localstorage-adapter": "^0.5.0"
  }
}

Although, the ember repo is fetched just fine, there is an error when npm is trying to resolve dependencies for ember-data , this is what I get in the console:

npm ERR! Linux 3.13.0-45-generic
npm ERR! argv "node" "/home/gargol/.nvm/v0.10.26/bin/npm" "install"
npm ERR! node v0.10.26
npm ERR! npm  v2.1.14
npm ERR! code ETARGET

npm ERR! notarget No compatible version found: ember@'>=1.8.1 <2.0.0'
npm ERR! notarget Valid install targets:
npm ERR! notarget ["0.9.7-1","0.9.8","0.9.8-1","1.0.0-pre","1.0.0-pre.m1","1.0.0-pre.m2","1.0.0-pre.2"]
npm ERR! notarget 
npm ERR! notarget This is most likely not a problem with npm itself.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

Any suggestions how this could be solved ?

[sindresorhus]

@gargol Ugh, what a mess. Let's just include ember-data manually for now.

@tomdale fyi.

[naz]

@sindresorhus updated PR with npm integration, left ember-data as a stand alone file that is not managed by npm for now.

[sindresorhus]

@gargol You have to include the files needed for running.

[naz]

@sindresorhus should be ok now

[sindresorhus]

Thank you @gargol :)

[naz]

@sindresorhus happy to help out any time 🎉

[addyosmani]

👍

[tomdale]

Ugh, that is a mess. Sorry for all the trouble. Is it possible to move the Ember example to Ember CLI? That would probably give people a better taste of the framework anyway, and all the bundling of dependencies is handled.

[sindresorhus]

@tomdale #1069 (comment)