Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto deploy is breaking the site... #1635

Closed
samccone opened this issue Jun 10, 2016 · 7 comments
Closed

auto deploy is breaking the site... #1635

samccone opened this issue Jun 10, 2016 · 7 comments

Comments

@samccone
Copy link
Member

seems to not be copying any of the root files :(

582130d
@samccone samccone mentioned this issue Jun 10, 2016
Merged
@samccone
Copy link
Member Author

samccone commented Jun 14, 2016 •
edited
Loading

A+ error gulp A+
https://travis-ci.org/tastejs/todomvc/builds/136589846#L1176

I have bisected this issue down to the ember cli commit... there is a funky file somewhere ---
8019b40

attempting to bisect further +1 for 🐵 patching gulp src for real logs 🐐

@addyosmani
Copy link
Member

Thanks for diving in to discover what's breaking the deploys @samccone 🍪 😎

@samccone
Copy link
Member Author

samccone commented Jun 15, 2016 •
edited
Loading

With a patch to vinyl-fs lib/src/getContents/index.js we can see the failure is coming from here

image

folder check is failing to detect that the symlink is a folder... thus is trying to read it as a file ... and 💀

image

Prob since we are using an old version of vinyl-fs
image

Looks like contra fixed this stuff in 4
image
gulpjs/vinyl-fs#57

Off to investigate what needs to be bumped for this to work

@samccone
Copy link
Member Author

image

gulp is latest ✅

gulp depends on old vinyl
https://github.com/gulpjs/gulp/blob/master/package.json#L41

gulpjs/gulp#1604

🐐

@samccone
Copy link
Member Author

samccone commented Jun 15, 2016 •
edited
Loading

Ok a few options

  1. figure out how to not symlink during the build phase in ember-cli
  2. write or use a third-party copy task that handles symlinks

@sindresorhus @addyosmani @passy do y'alll have opinions on this?

@samccone
Copy link
Member Author

Here is the origin issue from Oct 4, 2014 🌵
gulpjs/vinyl-fs#39

@sindresorhus
Copy link
Member

The second option sounds easier. Lots of copy modules on npm.

samccone added a commit that referenced this issue Jun 25, 2016
@samccone
Exit right away on error.
c1fc5ae 
This will prevent invalid deploys when we encounter errors instead of a
partial complete deploy.

ref #1635
samccone added a commit that referenced this issue Jun 25, 2016
@samccone
Exit right away on error.
f777d2f 
This will prevent invalid deploys when we encounter errors instead of a
partial complete deploy.

ref #1635
@samccone samccone mentioned this issue Jun 25, 2016
Merged
samccone added a commit that referenced this issue Jun 25, 2016
@samccone
Use vinyl fs directly for symlink fix
ea1d21e 
Fixes #1635
@samccone samccone mentioned this issue Jun 25, 2016
Merged
samccone added a commit that referenced this issue Jun 27, 2016
@samccone
Exit right away on error. (#1643)
31a5b94 
This will prevent invalid deploys when we encounter errors instead of a
partial complete deploy.

ref #1635
samccone added a commit that referenced this issue Jun 28, 2016
@samccone
Symlink fixup (#1644)
2d76560 
* Delete ancient ember version

* Rename ember-cli example to emberjs

* Update image min dep

* Use vinyl fs directly for symlink fix

Fixes #1635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@addyosmani @sindresorhus @samccone