-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(windows): allow web fullscreen APIs to work #13558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(windows): allow web fullscreen APIs to work #13558
Conversation
Package Changes Through 6cc8064There are 8 changes which include tauri-bundler with minor, tauri with minor, tauri-cli with minor, tauri-codegen with minor, tauri-utils with minor, @tauri-apps/api with minor, @tauri-apps/cli with minor, tauri-runtime-wry with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
I'll check macos in an hour or so. I don't think it behaves like this but didn't check for ages |
|
Since that's what the author said in #13557, I assumed it is the case, for Linux side, it seems to work like that in WSL at least |
|
i was so sure it worked like this on more platforms than just windows but i guess i didn't look closely enough when people talked about it in #support . And yes, can confirm that it's a proper fullscreen on macos. Which tbh is kinda sad, i'd imagine there are use cases for the current windows behavior. |
FabianLars
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No access to Windows today, so untested approval.
|
I have tested a few times and it seems to work fine 🙃 |
Reference: MicrosoftEdge/WebView2Feedback#1834
Fix #13557
I believe it works in this way on both Mac and Linux, so let's align this behavior on Windows as well