fix(cli): prevent .app identifier (fix #12674) #13618
Conversation
Package Changes Through 825fb73There are 8 changes which include tauri-bundler with minor, tauri-cli with minor, tauri-codegen with minor, tauri-utils with minor, @tauri-apps/cli with minor, tauri with minor, @tauri-apps/api with minor, tauri-runtime-wry with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Legend-Master
left a comment
Legend-Master
left a comment
There was a problem hiding this comment.
Thanks!
Since I'm not familiar with how this really works on macOS, I'll ask @FabianLars to review as well
|
I wonder if we should also update the default app id in |
Maybe we could prompt the user to set a custom appId, or just generate one from the project name |
|
Technically, we are doing that, just thinking we might want to get rid of the
|
|
this is actually a breaking change, there's a bunch of apps ending with |
| ); | ||
| std::process::exit(1); | ||
| } else { | ||
| log::warn!( |
There was a problem hiding this comment.
I would always warn instead of exiting like above
|
Yeah I suppose if you are not caring about macOS and you have a An opt-in CLI flag would not make sense to me but has tauri considered something like compatibility dates in configs so we can introduce semi-breaking changes like this? |
|
What about those that wkwebview creates? True about the braking change, didn't really think about that but imo we should still really consider making this a hard error in a future major. (With an opt-out for migrators ig) |
|
So I guess we just warn about it for now? I'm not sure if the directory is not usable or just can't be used in finder, if it's just in finder, I guess just a warning would be a better choice for now |
|
So should I do log::warn and remove log::error and exit from the code block ? |
|
Yeah, let's do that, we can always make it a hard fail in the future |
PR -> #13627, please check |
it's still usable, but Finder shows it as an app and you'd need to actually rightclick -> show package contents to open it |
5 participants
closes #12674