Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JKA Look Good #44

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Make JKA Look Good #44

wants to merge 6 commits into from

Conversation

taysta
Copy link
Owner

@taysta taysta commented Nov 4, 2023

Include some mods in the project with permission from their authors. Need to consider file size and deployment, do we make this optional, or just ship it with all releases? Still todo are WIP improved levelshots that are currently being cooked up.

Mods:
https://jkhub.org/files/file/2051-fixed-vchat/
https://jkhub.org/files/file/3014-circas-menu-mod/
https://jkhub.org/files/file/1000-smaller-character-menu-icons/
https://jkhub.org/files/file/2338-rgb-base-skins-30/
https://jkhub.org/files/file/2933-dynamic-light-for-weapons/
https://jkhub.org/files/file/2932-high-quality-icons/
https://jkhub.org/files/file/2476-high-quality-radar/
https://jkhub.org/files/file/2477-high-quality-sniper-scope/

From my tests so far this brings the assets.pk3 from ~40MB to ~95MB
Mods have been converted/adjusted where necessary

@taysta taysta force-pushed the update-assets branch 2 times, most recently from d335a13 to cbfea3d Compare January 5, 2024 09:37
@taysta taysta force-pushed the update-assets branch 2 times, most recently from 031985e to c95c1c1 Compare February 3, 2024 06:54
@CansecoDev
Copy link

Do you want me to check if those can me improved and/or optimized? Do we have permission to make changes to those?
About shipping them or making it optional, I'd say to ship them to make it simpler.

@CansecoDev
Copy link

CansecoDev commented Feb 8, 2024

PR #139 about the icons, I also must have better quality level-shots somewhere...

I'd not include this https://jkhub.org/files/file/2475-high-quality-fonts/ as it changes the font of the game too much, this one is not just "higher" quality but it changes the overall shape of the letters.

I can give all this a spin if we get permission to make changes.

@taysta
Copy link
Owner Author

taysta commented Feb 9, 2024

Do you want me to check if those can me improved and/or optimized? Do we have permission to make changes to those? About shipping them or making it optional, I'd say to ship them to make it simpler.

Absolutely, everything listed here I got permission for. If you see any optimizations fit, I'd be happy to try them out and possibly include them.

PR #139 about the icons, I also must have better quality level-shots somewhere...

I'd not include this https://jkhub.org/files/file/2475-high-quality-fonts/ as it changes the font of the game too much, this one is not just "higher" quality but it changes the overall shape of the letters.

I can give all this a spin if we get permission to make changes.

Circa of JKHub already provided me with some high quality levelshots for this PR, just haven't gotten around to adding them yet.

One thing I was probably going to change was the crosshairs - I think these use different designs to what is already standard for jaPRO/EternalJK. If you would be willing to look into verifying this, and at possibly seeing if there is a need for higher quality versions of what jaPRO already uses, that would be fantastic.

If you can optimize filesize/compression on anything already in this PR, that would be great also :)

@taysta taysta force-pushed the update-assets branch 2 times, most recently from d087a95 to 4fb0819 Compare February 27, 2024 15:07
@taysta taysta marked this pull request as ready for review February 27, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants