Editorial: Have RequireInternalSlot return the object #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most invocations of RequireInternalSlot take the form:
1. Let _O_ be the *this* value.
2. Perform ? RequireInternalSlot(_O_, [[Foo]]).
If we modify RequireInternalSlot to return the object (when successful),
we can reduce this idiom to:
1. Let _O_ be ? RequireInternalSlot(*this* value, [[Foo]]).
I think this is slightly better, because it tells you in a single line
that there are requirements on the *this* value.
ljharb
reviewed
Mar 21, 2021
|
This seems marginally worse to me - where previously a reader could infer what |
|
Editors are opposed for the reason I gave; closing. Thanks for the suggestion, though. (We should probably change ValidateTypedArray so that it doesn't return the buffer, to match |
jmdyck
added a commit
to jmdyck/ecma262
that referenced
this pull request
Apr 8, 2021
ljharb
pushed a commit
to jmdyck/ecma262
that referenced
this pull request
Jun 2, 2021
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most invocations of RequireInternalSlot take the form:
If we modify RequireInternalSlot to return the object (when successful), we can reduce this idiom to:
I think this is slightly better, because it tells you in a single line that there are requirements on the this value.